aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakob Unterwurzacher2018-08-15 12:28:29 +0200
committerJakob Unterwurzacher2018-08-15 12:28:29 +0200
commit7a02f71fc2fc8fc104ad1538f417d1e93e73cf11 (patch)
tree663a95888a011b68f22b8292dec4e891a05e81f7
parent8989905333f1f47d90e8874a36559c48a8f5ba50 (diff)
fusefrontend_reverse: reject excludes for the root directory ""
This is most likely a mistake by the user. Reject it.
-rw-r--r--internal/fusefrontend_reverse/isexcluded_test.go26
-rw-r--r--internal/fusefrontend_reverse/rfs.go9
2 files changed, 35 insertions, 0 deletions
diff --git a/internal/fusefrontend_reverse/isexcluded_test.go b/internal/fusefrontend_reverse/isexcluded_test.go
new file mode 100644
index 0000000..fc3831a
--- /dev/null
+++ b/internal/fusefrontend_reverse/isexcluded_test.go
@@ -0,0 +1,26 @@
+package fusefrontend_reverse
+
+import (
+ "testing"
+)
+
+func verifyExcluded(t *testing.T, rfs *ReverseFS, paths []string) {
+ for _, p := range paths {
+ if !rfs.isExcluded(p) {
+ t.Errorf("Path %q should be excluded, but is not", p)
+ }
+ }
+ if t.Failed() {
+ t.Logf("cExclude = %#v", rfs.cExclude)
+ }
+}
+
+// Note: See also the integration tests in
+// tests/reverse/exclude_test.go
+func TestIsExcluded(t *testing.T) {
+ var rfs ReverseFS
+ // If the root directory is excluded, all files and subdirs should be excluded
+ // as well
+ rfs.cExclude = []string{""}
+ verifyExcluded(t, &rfs, []string{"", "foo", "foo/bar"})
+}
diff --git a/internal/fusefrontend_reverse/rfs.go b/internal/fusefrontend_reverse/rfs.go
index ba8810c..1ca0b28 100644
--- a/internal/fusefrontend_reverse/rfs.go
+++ b/internal/fusefrontend_reverse/rfs.go
@@ -63,6 +63,10 @@ func NewFS(args fusefrontend.Args, c *contentenc.ContentEnc, n *nametransform.Na
if clean != dirty {
tlog.Warn.Printf("-exclude: non-canonical path %q has been interpreted as %q", dirty, clean)
}
+ if clean == "" {
+ tlog.Fatal.Printf("-exclude: excluding the root dir %q makes no sense", clean)
+ os.Exit(exitcodes.ExcludeError)
+ }
cPath, err := fs.EncryptPath(clean)
if err != nil {
tlog.Fatal.Printf("-exclude: EncryptPath %q failed: %v", clean, err)
@@ -90,6 +94,11 @@ func relDir(path string) string {
// (used when -exclude is passed by the user)
func (rfs *ReverseFS) isExcluded(relPath string) bool {
for _, e := range rfs.cExclude {
+ // If the root dir is excluded, everything is excluded.
+ if e == "" {
+ return true
+ }
+ // This exact path is excluded
if e == relPath {
return true
}