From 851188164274de96cd581c3da1b5e847a42e2948 Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Wed, 11 Nov 2026 21:22:00 +0100 Subject: fusefrontend: -sharedstorage: always check for file holes on write Write() skips writePadHole() when a write directly follows the previous one (isConsecutiveWrite), because such a write cannot create a hole. That decision is based on process-local state. With -sharedstorage, another mount may have shrunk the file in between, so the old partial last block was never padded and ended up as a short block in the middle of the file, making it unreadable (EIO). Disable the optimization with -sharedstorage. Add TestConsecutiveWriteAfterRemoteTruncate as a regression test. Co-Authored-By: Claude Opus 5.5 --- tests/cluster/cluster_test.go | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) (limited to 'tests') diff --git a/tests/cluster/cluster_test.go b/tests/cluster/cluster_test.go index f08d3d0..813834e 100644 --- a/tests/cluster/cluster_test.go +++ b/tests/cluster/cluster_test.go @@ -288,3 +288,36 @@ func TestGrowAfterTruncateKeepsHeader(t *testing.T) { t.Errorf("wrong content: got %q, want %q", buf, want) } } + +// Write() skips hole padding when a write directly follows the previous one, +// based on process-local state. With -sharedstorage, another mount may have +// shrunk the file in between, leaving the old partial last block unpadded +// in the middle of the file, making it unreadable. +func TestConsecutiveWriteAfterRemoteTruncate(t *testing.T) { + mnt1, mnt2 := mountTwice(t) + f1, err := os.Create(mnt1 + "/foo") + if err != nil { + t.Fatal(err) + } + defer f1.Close() + if _, err := f1.WriteAt(bytes.Repeat([]byte("a"), 8192), 0); err != nil { + t.Fatal(err) + } + // mount2 shrinks the file so that the second block is partial + if err := os.Truncate(mnt2+"/foo", 5000); err != nil { + t.Fatal(err) + } + // mount1 continues writing where it left off, creating a hole + if _, err := f1.WriteAt(bytes.Repeat([]byte("b"), 4096), 8192); err != nil { + t.Fatal(err) + } + want := append(bytes.Repeat([]byte("a"), 5000), make([]byte, 8192-5000)...) + want = append(want, bytes.Repeat([]byte("b"), 4096)...) + have, err := os.ReadFile(mnt2 + "/foo") + if err != nil { + t.Fatalf("ReadFile: %v", err) + } + if !bytes.Equal(have, want) { + t.Errorf("wrong content: len(have)=%d, len(want)=%d", len(have), len(want)) + } +} -- cgit v1.2.3