From 2d68b06f9dab66b2a0a6c29c8d5450e2b1d43fae Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Sun, 1 Jul 2018 19:14:00 +0200 Subject: fsck: handle sparse files efficiently, fix xfstests generic/285 If we encounter a 128KB block of zeros, try to skip to the next data section by calling File.SeekData(). This fixes xfstests generic/285, which creates a 17TB sparse file, and runs fsck afterwards. Without this optimization, fsck would take ages. --- tests/fsck/fsck_test.go | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) (limited to 'tests') diff --git a/tests/fsck/fsck_test.go b/tests/fsck/fsck_test.go index 8e73cf7..5ece6cd 100644 --- a/tests/fsck/fsck_test.go +++ b/tests/fsck/fsck_test.go @@ -4,8 +4,10 @@ import ( "encoding/base64" "os" "os/exec" + "runtime" "strings" "testing" + "time" "github.com/pkg/xattr" @@ -84,3 +86,41 @@ func TestExampleFses(t *testing.T) { } } } + +// TestTerabyteFile verifies that fsck does something intelligent when it hits +// a 1-terabyte sparse file (trying to read the whole file is not intelligent). +func TestTerabyteFile(t *testing.T) { + if runtime.GOOS != "linux" { + t.Skipf("Only linux supports SEEK_DATA") + } + cDir := test_helpers.InitFS(t) + pDir := cDir + ".mnt" + test_helpers.MountOrFatal(t, cDir, pDir, "-extpass", "echo test") + defer test_helpers.UnmountErr(pDir) + exabyteFile := pDir + "/exabyteFile" + fd, err := os.Create(exabyteFile) + if err != nil { + t.Fatal(err) + } + defer fd.Close() + var oneTiB int64 = 1024 * 1024 * 1024 * 1024 + _, err = fd.WriteAt([]byte("foobar"), oneTiB) + if err != nil { + t.Fatal(err) + } + fi, err := fd.Stat() + if err != nil { + t.Fatal(err) + } + t.Logf("size=%d, running fsck", fi.Size()) + cmd := exec.Command(test_helpers.GocryptfsBinary, "-fsck", "-extpass", "echo test", cDir) + cmd.Stderr = os.Stderr + cmd.Stdout = os.Stdout + cmd.Start() + timer := time.AfterFunc(10*time.Second, func() { + cmd.Process.Kill() + t.Fatalf("timeout") + }) + cmd.Wait() + timer.Stop() +} -- cgit v1.2.3