From 0363a138f8125604d75d9ca84be4092482b622df Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Wed, 11 Nov 2026 21:21:13 +0100 Subject: fusefrontend: -sharedstorage: don't replace the header when growing a truncated file With -sharedstorage, truncate to zero keeps the file header, because other mounts may have the file ID cached. But a following truncate that grows the file to a block-aligned size went through truncateGrowFile, which saw plaintext size 0 and unconditionally called createHeader(). This replaced the file ID (without taking the header lock), and everything the other mount wrote afterwards with its cached ID was unreadable. Factor the "read header or create it if the file is empty" logic out of doWrite into loadOrCreateFileID() and use it in truncateGrowFile with -sharedstorage. Add TestGrowAfterTruncateKeepsHeader as a regression test. Co-Authored-By: Claude Opus 5.5 --- tests/cluster/cluster_test.go | 62 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) (limited to 'tests') diff --git a/tests/cluster/cluster_test.go b/tests/cluster/cluster_test.go index 70a2a02..f08d3d0 100644 --- a/tests/cluster/cluster_test.go +++ b/tests/cluster/cluster_test.go @@ -226,3 +226,65 @@ func TestOpenTruncate(t *testing.T) { go writerThread(mnt2 + "/foo") wg.Wait() } + +// mountTwice creates a new filesystem and mounts it twice with -sharedstorage. +func mountTwice(t *testing.T) (mnt1 string, mnt2 string) { + cDir := test_helpers.InitFS(t) + mnt1 = cDir + ".mnt1" + mnt2 = cDir + ".mnt2" + test_helpers.MountOrFatal(t, cDir, mnt1, "-extpass=echo test", "-wpanic=0", "-sharedstorage") + t.Cleanup(func() { test_helpers.UnmountPanic(mnt1) }) + test_helpers.MountOrFatal(t, cDir, mnt2, "-extpass=echo test", "-wpanic=0", "-sharedstorage") + t.Cleanup(func() { test_helpers.UnmountPanic(mnt2) }) + return +} + +// With -sharedstorage, truncate to zero keeps the file header because other +// mounts may have the file ID cached. Growing the file to a block-aligned size +// afterwards used to create a new header, replacing the file ID the other +// mount was still using, corrupting everything it wrote afterwards. +func TestGrowAfterTruncateKeepsHeader(t *testing.T) { + mnt1, mnt2 := mountTwice(t) + f1, err := os.Create(mnt1 + "/foo") + if err != nil { + t.Fatal(err) + } + defer f1.Close() + if _, err := f1.WriteAt([]byte("xxxxxxxx"), 0); err != nil { + t.Fatal(err) + } + f2, err := os.OpenFile(mnt2+"/foo", os.O_RDWR, 0) + if err != nil { + t.Fatal(err) + } + defer f2.Close() + // Make mount2 cache the file ID + if _, err := f2.ReadAt(make([]byte, 8), 0); err != nil { + t.Fatal(err) + } + // mount1: truncate to zero, then grow to exactly one block + if err := f1.Truncate(0); err != nil { + t.Fatal(err) + } + if err := f1.Truncate(4096); err != nil { + t.Fatal(err) + } + // mount2 writes using its cached file ID + want := []byte("hello") + if _, err := f2.WriteAt(want, 0); err != nil { + t.Fatal(err) + } + // A fresh open on mount1 (reads the file ID from disk) must see the data + f3, err := os.Open(mnt1 + "/foo") + if err != nil { + t.Fatal(err) + } + defer f3.Close() + buf := make([]byte, len(want)) + if _, err := f3.ReadAt(buf, 0); err != nil { + t.Fatalf("ReadAt: %v", err) + } + if !bytes.Equal(buf, want) { + t.Errorf("wrong content: got %q, want %q", buf, want) + } +} -- cgit v1.2.3