From 700ae685cc7cb99b396caeaeee4e39eeac20f1c7 Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Tue, 4 Jan 2022 15:21:20 +0100 Subject: tests: improve SEEK_DATA test for MacOS (1) Create a 1 GiB file instead of 1 TiB, because apparently, on MacOS, the file (sometimes?) is not created sparse, and fills up users' disks: https://github.com/rfjakob/gocryptfs/issues/625 (2) On darwin, SEEK_DATA is not the same as on Linux ( https://github.com/golang/go/commit/2f8b555de27198775f9606e001ef19b76efdb415 ) so use the value provided by the unix package. --- tests/reverse/correctness_test.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'tests/reverse') diff --git a/tests/reverse/correctness_test.go b/tests/reverse/correctness_test.go index 090a468..4a5224c 100644 --- a/tests/reverse/correctness_test.go +++ b/tests/reverse/correctness_test.go @@ -259,7 +259,7 @@ func TestStatfs(t *testing.T) { } } -// TestSeekData tests that fs.FileLseeker is implemented +// TestSeekData tests that SEEK_DATA works func TestSeekData(t *testing.T) { if !plaintextnames { t.Skip() @@ -270,8 +270,8 @@ func TestSeekData(t *testing.T) { if err != nil { t.Fatal(err) } - var oneTiB int64 = 1024 * 1024 * 1024 * 1024 - if _, err = f.Seek(oneTiB, 0); err != nil { + var dataOffset int64 = 1 * 1024 * 1024 * 1024 // 1 GiB + if _, err = f.Seek(dataOffset, 0); err != nil { t.Fatal(err) } if _, err = f.Write([]byte("foo")); err != nil { @@ -279,19 +279,17 @@ func TestSeekData(t *testing.T) { } f.Close() - const SEEK_DATA = 3 - fn2 := filepath.Join(dirB, t.Name()) f, err = os.Open(fn2) if err != nil { t.Fatal(err) } - off, err := f.Seek(1024*1024, SEEK_DATA) + off, err := f.Seek(1024*1024, unix.SEEK_DATA) if err != nil { t.Fatal(err) } - if off < oneTiB-1024*1024 { - t.Errorf("off=%d, expected=%d\n", off, oneTiB) + if off < dataOffset-1024*1024 { + t.Errorf("off=%d, expected=%d\n", off, dataOffset) } f.Close() } -- cgit v1.2.3