From 3064d72b9774029ab89daea8a7fccfe181c3cae0 Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Mon, 5 Mar 2018 21:56:30 +0100 Subject: tests: fix a few fd leaks We relied on the finalizer to close a few fds. For some reason, this did not cause problems on Linux, but on MacOS, it causes unmount failures: umount(/private/tmp/gocryptfs-test-parent/194654785/default-plain): Resource busy -- try 'diskutil unmount' --- tests/defaults/main_test.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'tests/defaults/main_test.go') diff --git a/tests/defaults/main_test.go b/tests/defaults/main_test.go index 5c6bb84..49c6dcf 100644 --- a/tests/defaults/main_test.go +++ b/tests/defaults/main_test.go @@ -51,6 +51,7 @@ func TestOpenTruncateRead(t *testing.T) { if err != nil { t.Fatal(err) } + defer writeFd.Close() abc := []byte("abc") _, err = writeFd.WriteAt(abc, 0) if err != nil { @@ -61,6 +62,7 @@ func TestOpenTruncateRead(t *testing.T) { if err != nil { t.Fatal(err) } + defer readFd.Close() content := make([]byte, 3) _, err = readFd.ReadAt(content, 0) if err != nil { -- cgit v1.2.3