From b7843e85ed699fe597834ad60bffc2035a5bba2b Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Wed, 18 Nov 2026 21:09:17 +0100 Subject: syscallcompat: listxattrSmartBuf: fix panic on unsupported listxattr go-fuse: panic in FS handler: runtime error: slice bounds out of range [:-1] goroutine 50 [running]: github.com/hanwen/go-fuse/v2/fuse.defaultPanicHandler([...], {[...], [...]}) github.com/hanwen/go-fuse/v2@v2.12.1-0.20261018182834-2d50fff207d7/fuse/server.go:183 +[...] github.com/hanwen/go-fuse/v2/fuse.(*MountOptions).setDefaults.func1({[...]?, [...]?}) github.com/hanwen/go-fuse/v2@v2.12.1-0.20261018182834-2d50fff207d7/fuse/server.go:162 +[...] github.com/hanwen/go-fuse/v2/fuse.(*protocolServer).handleRequest.func1.1() github.com/hanwen/go-fuse/v2@v2.12.1-0.20261018182834-2d50fff207d7/fuse/protocol-server.go:70 +[...] panic({[...]?, [...]?}) runtime/panic.go:859 +[...] github.com/rfjakob/gocryptfs/v2/internal/syscallcompat.listxattrSmartBuf([...]) github.com/rfjakob/gocryptfs/v2/internal/syscallcompat/sys_common.go:222 +[...] github.com/rfjakob/gocryptfs/v2/internal/syscallcompat.Llistxattr({[...]?, [...]?}) github.com/rfjakob/gocryptfs/v2/internal/syscallcompat/sys_common.go:197 +[...] github.com/rfjakob/gocryptfs/v2/internal/fusefrontend.(*Node).listXAttr([...]?) github.com/rfjakob/gocryptfs/v2/internal/fusefrontend/node_xattr_linux.go:68 +[...] Fixes 700432ec25aad389465124d0defffb2b8cca431d Closes https://github.com/rfjakob/gocryptfs/issues/1055 --- internal/syscallcompat/sys_common.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'internal/syscallcompat') diff --git a/internal/syscallcompat/sys_common.go b/internal/syscallcompat/sys_common.go index bdd2dac..7c11a53 100644 --- a/internal/syscallcompat/sys_common.go +++ b/internal/syscallcompat/sys_common.go @@ -203,6 +203,8 @@ func listxattrSmartBuf(listxattrSyscall func([]byte) (int, error)) ([]string, er // we could fail with ERANGE. This is ok as the caller will retry. return nil, err } + } else if err != nil { + return nil, err } return parseListxattrBlob(buf[:sz]), nil } -- cgit v1.2.3