From 386232f39ede046d6453a0990ad40f2d86a26f53 Mon Sep 17 00:00:00 2001
From: copilot-swe-agent[bot]
Date: Mon, 7 Jul 2025 18:18:12 +0000
Subject: Fix all staticcheck errors in gocryptfs codebase

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Add staticcheck to test.bash for continuous static analysis

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Fix nil pointer dereference in timesToTimespec function

The previous fix for deprecated fuse.UtimeToTimespec caused a panic
because unix.TimeToTimespec doesn't handle nil pointers. This fix
properly handles nil pointers by using unix.UTIME_OMIT while still
using the non-deprecated unix.TimeToTimespec function.

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Undo SA6002 changes and add staticcheck ignore directive instead

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>
---
 internal/siv_aead/correctness_test.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'internal/siv_aead')

diff --git a/internal/siv_aead/correctness_test.go b/internal/siv_aead/correctness_test.go
index 0653e26..7be97bc 100644
--- a/internal/siv_aead/correctness_test.go
+++ b/internal/siv_aead/correctness_test.go
@@ -50,7 +50,7 @@ func TestK32(t *testing.T) {
 	expectedResult, _ := hex.DecodeString(
 		"02020202020202020202020202020202ad7a4010649a84d8c1dd5f752e935eed57d45b8b10008f3834")
 	if !bytes.Equal(aResult, expectedResult) {
-		t.Errorf(hex.EncodeToString(aResult))
+		t.Error(hex.EncodeToString(aResult))
 	}
 	// Verify overhead
 	overhead := len(aResult) - len(plaintext) - len(nonce)
@@ -108,7 +108,7 @@ func TestK64(t *testing.T) {
 	expectedResult, _ := hex.DecodeString(
 		"02020202020202020202020202020202317b316f67c3ad336c01c9a01b4c5e552ba89e966bc4c1ade1")
 	if !bytes.Equal(aResult, expectedResult) {
-		t.Errorf(hex.EncodeToString(aResult))
+		t.Error(hex.EncodeToString(aResult))
 	}
 	// Verify overhead
 	overhead := len(aResult) - len(plaintext) - len(nonce)
-- 
cgit v1.2.3