From 14045511d3d91f36845a138359718c0fe7dff21c Mon Sep 17 00:00:00 2001
From: Jakob Unterwurzacher
Date: Mon, 2 Feb 2026 22:18:25 +0100
Subject: Use user-provided Listxattr buffer size

This huge buffer showed up big time in ./profiling/ls.bash
and caused a 2x LS benchmark slowdown.

Instead of the fixed-size buffer, use the buffer size
hint the user has provided us.

We return inaccurate (larger than actual, which should be safe)
numbers when the user has provided no buffer (size probe).
---
 internal/fusefrontend/node_xattr_darwin.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

(limited to 'internal/fusefrontend/node_xattr_darwin.go')

diff --git a/internal/fusefrontend/node_xattr_darwin.go b/internal/fusefrontend/node_xattr_darwin.go
index f8f224f..ad0cd9e 100644
--- a/internal/fusefrontend/node_xattr_darwin.go
+++ b/internal/fusefrontend/node_xattr_darwin.go
@@ -88,7 +88,7 @@ func (n *Node) removeXAttr(cAttr string) (errno syscall.Errno) {
 	return fs.ToErrno(err)
 }
 
-func (n *Node) listXAttr() (out []string, errno syscall.Errno) {
+func (n *Node) listXAttr(buf []byte) (sz int, errno syscall.Errno) {
 	dirfd, cName, errno := n.prepareAtSyscallMyself()
 	if errno != 0 {
 		return
@@ -98,13 +98,10 @@ func (n *Node) listXAttr() (out []string, errno syscall.Errno) {
 	// O_NONBLOCK to not block on FIFOs.
 	fd, err := syscallcompat.Openat(dirfd, cName, syscall.O_RDONLY|syscall.O_NONBLOCK|syscall.O_NOFOLLOW, 0)
 	if err != nil {
-		return nil, fs.ToErrno(err)
+		return 0, fs.ToErrno(err)
 	}
 	defer syscall.Close(fd)
 
-	cNames, err := syscallcompat.Flistxattr(fd)
-	if err != nil {
-		return nil, fs.ToErrno(err)
-	}
-	return cNames, 0
+	sz, err = unix.Flistxattr(fd, buf)
+	return sz, fs.ToErrno(err)
 }
-- 
cgit v1.2.3