From a7d59032d3790e117a48be6be1fb3a968266093b Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Mon, 14 Jan 2019 21:54:16 +0100 Subject: syscallcompat: rework Fchmodat to FchmodatNofollow We never want Fchmodat to follow symlinks, so follow what Qemu does, and call our function FchmodatNofollow. --- internal/fusefrontend/fs_dir.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'internal/fusefrontend/fs_dir.go') diff --git a/internal/fusefrontend/fs_dir.go b/internal/fusefrontend/fs_dir.go index a017050..d26fd79 100644 --- a/internal/fusefrontend/fs_dir.go +++ b/internal/fusefrontend/fs_dir.go @@ -164,7 +164,7 @@ func (fs *FS) Rmdir(relPath string, context *fuse.Context) (code fuse.Status) { } // This cast is needed on Darwin, where st.Mode is uint16. origMode := uint32(st.Mode) - err = syscallcompat.Fchmodat(parentDirFd, cName, origMode|0700, unix.AT_SYMLINK_NOFOLLOW) + err = syscallcompat.FchmodatNofollow(parentDirFd, cName, origMode|0700) if err != nil { tlog.Debug.Printf("Rmdir: Fchmodat failed: %v", err) return fuse.ToStatus(err) @@ -175,7 +175,7 @@ func (fs *FS) Rmdir(relPath string, context *fuse.Context) (code fuse.Status) { // Undo the chmod if removing the directory failed defer func() { if code != fuse.OK { - err = syscallcompat.Fchmodat(parentDirFd, cName, origMode, unix.AT_SYMLINK_NOFOLLOW) + err = syscallcompat.FchmodatNofollow(parentDirFd, cName, origMode) if err != nil { tlog.Warn.Printf("Rmdir: Chmod rollback failed: %v", err) } -- cgit v1.2.3