From 745276fe6e2b81570e5c84625699d632da5fd6a9 Mon Sep 17 00:00:00 2001
From: Jakob Unterwurzacher
Date: Sun, 14 Dec 2025 11:38:45 +0100
Subject: Drop deprecated rand.Seed calls

$ staticcheck --version
staticcheck 2025.1.1 (0.6.1)

$ staticcheck ./...
contrib/findholes/holes/holes.go:179:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
tests/defaults/acl_test.go:24:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
tests/plaintextnames/file_holes_test.go:143:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
---
 contrib/findholes/holes/holes.go        | 2 --
 tests/defaults/acl_test.go              | 3 ---
 tests/plaintextnames/file_holes_test.go | 2 --
 3 files changed, 7 deletions(-)

diff --git a/contrib/findholes/holes/holes.go b/contrib/findholes/holes/holes.go
index d298efb..72f5114 100644
--- a/contrib/findholes/holes/holes.go
+++ b/contrib/findholes/holes/holes.go
@@ -8,7 +8,6 @@ import (
 	"math/rand"
 	"os"
 	"syscall"
-	"time"
 )
 
 const (
@@ -176,7 +175,6 @@ func Create(path string) {
 	}
 	defer f.Close()
 
-	rand.Seed(time.Now().UnixNano())
 	offsets := make([]int64, 10)
 	for i := range offsets {
 		offsets[i] = int64(rand.Int31n(60000))
diff --git a/tests/defaults/acl_test.go b/tests/defaults/acl_test.go
index 0dae018..bddb5e5 100644
--- a/tests/defaults/acl_test.go
+++ b/tests/defaults/acl_test.go
@@ -7,7 +7,6 @@ import (
 	"path/filepath"
 	"syscall"
 	"testing"
-	"time"
 
 	"golang.org/x/sys/unix"
 
@@ -21,8 +20,6 @@ func TestCpA(t *testing.T) {
 	fn1 := filepath.Join(test_helpers.TmpDir, t.Name())
 	fn2 := filepath.Join(test_helpers.DefaultPlainDir, t.Name())
 
-	rand.Seed(int64(time.Now().Nanosecond()))
-
 	{
 		// Need unrestricted umask
 		old := syscall.Umask(000)
diff --git a/tests/plaintextnames/file_holes_test.go b/tests/plaintextnames/file_holes_test.go
index ea47113..7a356c0 100644
--- a/tests/plaintextnames/file_holes_test.go
+++ b/tests/plaintextnames/file_holes_test.go
@@ -7,7 +7,6 @@ import (
 	"os/exec"
 	"syscall"
 	"testing"
-	"time"
 
 	"github.com/rfjakob/gocryptfs/v2/tests/test_helpers"
 
@@ -140,7 +139,6 @@ func TestFileHoleCopy(t *testing.T) {
 		return
 	}
 
-	rand.Seed(time.Now().UnixNano())
 	for k := 0; k < 100; k++ {
 		c1 := make([]int64, 10)
 		for i := range c1 {
-- 
cgit v1.2.3