From 4851c322d5ce06c559eed9e9f3cb0a5c2c72fd5e Mon Sep 17 00:00:00 2001 From: Jakob Unterwurzacher Date: Sun, 13 Apr 2025 11:48:22 +0200 Subject: Revert "Build with v2 extensions" / GOAMD64=v2 As seen in https://github.com/rfjakob/gocryptfs/issues/908, there are users still running x86-64-v1 cpus. They get This program can only be run on AMD64 processors with v2 microarchitecture support. and cannot read their encrypted files. Build for AMD64v1 again an accept the XChaCha20 performance hit for for some cpus ( https://github.com/golang/go/issues/67240 ). This reverts commit f5007b28c366d1a9671146710975679a154f30f8. Related: https://github.com/rfjakob/gocryptfs/issues/828 https://github.com/rfjakob/gocryptfs/pull/833 https://github.com/apptainer/apptainer/issues/2873 https://github.com/golang/go/issues/67240 --- build.bash | 3 --- 1 file changed, 3 deletions(-) diff --git a/build.bash b/build.bash index ffdd307..5e95c3e 100755 --- a/build.bash +++ b/build.bash @@ -85,9 +85,6 @@ if [[ -n ${LDFLAGS:-} ]] ; then GO_LDFLAGS="$GO_LDFLAGS \"-extldflags=$LDFLAGS\"" fi -# Set GOAMD64 version to v2 -export GOAMD64=v2 - # Actual "go build" call for gocryptfs go build "-ldflags=$GO_LDFLAGS" "$@" # Additional binaries -- cgit v1.2.3