| Age | Commit message (Collapse) | Author |
|
|
|
This has become untenable as the golang.org/x
packages started bumping their go.mod go directive
automatically:
https://github.com/golang/go/issues/69095
https://go.googlesource.com/proposal/+/HEAD/design/69095-x-repo-continuous-go.md
|
|
$ staticcheck --version
staticcheck 2025.1.1 (0.6.1)
$ staticcheck ./...
contrib/findholes/holes/holes.go:179:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
tests/defaults/acl_test.go:24:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
tests/plaintextnames/file_holes_test.go:143:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019)
|
|
$ go version
go version go1.25.4 linux/amd64
$ go vet ./...
./init_dir.go:71:21: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
./main.go:123:19: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
./masterkey.go:29:20: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
./masterkey.go:56:20: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
./mount.go:415:20: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
internal/tlog/log.go:76:18: non-constant format string in call to (*log.Logger).Printf
internal/syscallcompat/quirks.go:19:19: non-constant format string in call to (*github.com/rfjakob/gocryptfs/v2/internal/tlog.toggledLogger).Printf
|
|
tmpfs supports user xattrs since Linux 6.6 (anno 2023):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2daf18a7884dc03d5164ab9c7dc3f2ea70638469
|
|
On my Fedora I used to get this failure:
--- FAIL: TestXattrList (0.00s)
xattr_test.go:52: wrong number of names, want=20 have=21
xattr_test.go:58: mismatch on attr "security.selinux": valA = "", valC = "xxxxxxxxyyyyyyyyyyyyyyyzzzzzzzzzzzzz"
First step is to print the actual value using xattr.LGet.
This improves the error message to this:
--- FAIL: TestXattrList (0.00s)
xattr_test.go:53: wrong number of names, want=20 have=21
xattr_test.go:59: mismatch on attr "security.selinux": valA = "", valC = "system_u:object_r:fusefs_t:s0\x00"
2nd step is to ignore "security." attribs as we have no control
over them.
|
|
Fixes https://github.com/rfjakob/gocryptfs/issues/827
|
|
https://github.com/libfuse/libfuse/commit/bf3dd153fbfcd610d799562490f6555b9d708905
|
|
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v5)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
|
|
Fixes https://github.com/rfjakob/gocryptfs/issues/964
|
|
--- FAIL: Test555Dir (0.00s)
dir_test.go:90: wrong mode. want 0555 have 0755
FAIL
TestMain: matrix[0] = matrix.testcaseMatrix{plaintextnames:false, openssl:"auto", aessiv:false, raw64:false, extraArgs:[]string(nil)} failed
FAIL github.com/rfjakob/gocryptfs/v2/tests/matrix 2.109s
https://github.com/rfjakob/gocryptfs/issues/964
|
|
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v5...v6)
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: '6'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4...v5)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
|
|
Because the deletion happens asynchronously, a
previous iteration can delete the socket of the
next one.
|
|
Added testing for RENAME_EXCHANGE
https://github.com/rfjakob/gocryptfs/issues/914
|
|
Fix macos file saving problem by implementing RENAME_EXCHANGE flag.
With test.
The dummy value for RENAME_WHITEOUT collides with the new
flags. Move it wayyy up.
https://github.com/rfjakob/gocryptfs/issues/914
|
|
|
|
This makes building with just CGO_ENABLED=0 work.
|
|
|
|
We used to get this:
Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/gocryptfs/gocryptfs. Supported file pattern: go.sum
Hopefully make it go away by checking out the code first.
Fixes https://github.com/rfjakob/gocryptfs/issues/946
|
|
|
|
No longer needed.
|
|
From man 1 flock:
shell> exec 4<>/var/lock/mylockfile; shell> flock -n 4
This form is convenient for locking a file without spawning a
subprocess. The shell opens the lock file for reading and
writing as file descriptor 4, then flock is used to lock the
descriptor.
|
|
Fixes https://github.com/rfjakob/gocryptfs/issues/951
|
|
Fails at the moment, as expected:
=== RUN TestDirSize
matrix_test.go:938: stat size is different from fstat size: pStat=80 pFstat=30
matrix_test.go:941: fstat size is different: pSt=30 cSt=80
matrix_test.go:938: stat size is different from fstat size: pStat=100 pFstat=50
matrix_test.go:941: fstat size is different: pSt=50 cSt=100
matrix_test.go:938: stat size is different from fstat size: pStat=120 pFstat=70
matrix_test.go:941: fstat size is different: pSt=70 cSt=120
matrix_test.go:938: stat size is different from fstat size: pStat=140 pFstat=90
matrix_test.go:941: fstat size is different: pSt=90 cSt=140
matrix_test.go:938: stat size is different from fstat size: pStat=160 pFstat=110
matrix_test.go:941: fstat size is different: pSt=110 cSt=160
https://github.com/rfjakob/gocryptfs/issues/951
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: '4'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v3...v5)
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
|
|
|
|
|
|
|
|
Fixes https://github.com/rfjakob/gocryptfs/issues/930
|
|
|
|
|
|
Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>
Add staticcheck to test.bash for continuous static analysis
Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>
Fix nil pointer dereference in timesToTimespec function
The previous fix for deprecated fuse.UtimeToTimespec caused a panic
because unix.TimeToTimespec doesn't handle nil pointers. This fix
properly handles nil pointers by using unix.UTIME_OMIT while still
using the non-deprecated unix.TimeToTimespec function.
Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>
Undo SA6002 changes and add staticcheck ignore directive instead
Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>
|
|
Tool-assisted.
|
|
Before:
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setuid(uid)
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setgid(gid)
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setreuid(ruid, euid)
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setregid(rgid, egid)
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setresuid(ruid, euid, suid)
./vendor/golang.org/x/sys/unix/syscall_linux.go: return syscall.Setresgid(rgid, egid, sgid)
test.bash: This affects the whole process. Please use the syscallcompat wrappers instead.
After: clean
https://github.com/rfjakob/gocryptfs/issues/930
|
|
golint is dead since 2021
|
|
|
|
|
|
|
|
Will be used soon in a new gitignore test.
Relates-to: https://github.com/rfjakob/gocryptfs/issues/927
|
|
Apparently, the check does not work on some distributions,
notably Ubuntu 24.04. On Ubuntu 24.04, ldd exits with 0
(success) even when run against a static binary.
Even "ld.so --verify" returns 0, and "file" output
is indistinguishable for static and dynamic builds.
We could go for objdump or readelf, but this is not
installed per default.
Just drop the check. By now, I trust that CGO_ENABLED=0
will always build a static binary.
Fixes https://github.com/rfjakob/gocryptfs/issues/926
|