diff options
| author | Jakob Unterwurzacher | 2021-08-18 15:47:17 +0200 |
|---|---|---|
| committer | Jakob Unterwurzacher | 2021-08-18 15:48:01 +0200 |
| commit | 64793fedf4ac8eebe05c57af75877944c60f03a4 (patch) | |
| tree | 02f3d4840dabd2c1e49e3356293507edd898aa83 /tests/xattr | |
| parent | dc52e3215147e3f805be64705ee9e07a2cc453ee (diff) | |
Fix issues found by ineffassign
gocryptfs$ ineffassign ./...
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:243:2: ineffectual assignment to scryptHash
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:272:2: ineffectual assignment to scryptHash
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:285:3: ineffectual assignment to fileID
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node.go:367:3: ineffectual assignment to err
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node_open_create.go:68:2: ineffectual assignment to fd
/home/jakob/go/src/github.com/rfjakob/gocryptfs/mount.go:308:2: ineffectual assignment to masterkey
/home/jakob/go/src/github.com/rfjakob/gocryptfs/gocryptfs-xray/xray_main.go:156:13: ineffectual assignment to err
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/prepare_syscall_test.go:65:16: ineffectual assignment to errno
/home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/syscallcompat/open_nofollow_test.go:34:2: ineffectual assignment to fd
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:111:6: ineffectual assignment to err
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:181:2: ineffectual assignment to sz
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:198:2: ineffectual assignment to sz
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:365:8: ineffectual assignment to err
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:30:6: ineffectual assignment to err
/home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:66:6: ineffectual assignment to err
Diffstat (limited to 'tests/xattr')
| -rw-r--r-- | tests/xattr/xattr_fd_test.go | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/tests/xattr/xattr_fd_test.go b/tests/xattr/xattr_fd_test.go index d3f02c5..7415e54 100644 --- a/tests/xattr/xattr_fd_test.go +++ b/tests/xattr/xattr_fd_test.go @@ -28,7 +28,9 @@ func TestFdXattr(t *testing.T) { defer syscall.Close(fd) buf := make([]byte, 1000) sz, err := unix.Flistxattr(fd, buf) - if sz != 0 { + if err != nil { + t.Error(err) + } else if sz != 0 { t.Errorf("expected zero size, got %d", sz) } val1 := []byte("123456789") @@ -64,7 +66,9 @@ func TestFdXattr(t *testing.T) { t.Error(err) } sz, err = unix.Flistxattr(fd, buf) - if sz != 0 { + if err != nil { + t.Error(err) + } else if sz != 0 { t.Errorf("expected zero size, got %d", sz) } } |