Fix all staticcheck errors in gocryptfs codebase

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Add staticcheck to test.bash for continuous static analysis

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Fix nil pointer dereference in timesToTimespec function

The previous fix for deprecated fuse.UtimeToTimespec caused a panic
because unix.TimeToTimespec doesn't handle nil pointers. This fix
properly handles nil pointers by using unix.UTIME_OMIT while still
using the non-deprecated unix.TimeToTimespec function.

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Undo SA6002 changes and add staticcheck ignore directive instead

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

1 files changed, 6 insertions, 0 deletions

diff --git a/test.bash b/test.bash
index 2b78d17..bf3b78d 100755
--- a/test.bash
+++ b/test.bash
@@ -67,6 +67,12 @@ else
 	go vet ./...
 fi
 
+if command -v staticcheck > /dev/null ; then
+	staticcheck ./...
+else
+	echo "staticcheck not installed - skipping"
+fi
+
 if command -v shellcheck > /dev/null ; then
 	# SC2002 = useless cat. Does no harm, disable the check.
 	shellcheck -x -e SC2002 ./*.bash