diff options
author | Sebastian Lackner | 2019-01-16 15:38:32 +0100 |
---|---|---|
committer | Jakob Unterwurzacher | 2019-01-16 20:55:20 +0100 |
commit | 682e642cfa556c2d72c4050bfb8e38febdec49b3 (patch) | |
tree | 5c17005d3a2506da59dacd851eb586c544b239d0 /internal/tlog/log.go | |
parent | 1d2ce9c213093c91b86ba6c28537ccda4469fe1f (diff) |
fusefrontend: Rework the Utimens handling on macOS.
For Linux, everything effectively stays the same. For both path-based and
fd-based Utimens() calls, we use unix.UtimesNanoAt(). To avoid introducing
a separate syscall wrapper for futimens() (as done in go-fuse, for example),
we instead use the /proc/self/fd - trick.
On macOS, this changes quite a lot:
* Path-based Utimens() calls were previously completely broken, since
unix.UtimensNanoAt() ignores the passed file descriptor. Note that this
cannot be fixed easily since there IS no appropriate syscall available on
macOS prior to High Sierra (10.13). We emulate this case by using
Fchdir() + setattrlist().
* Fd-based Utimens() calls were previously translated to f.GetAttr() (to
fill any empty parameters) and syscall.Futimes(), which does not does
support nanosecond precision. Both issues can be fixed by switching to
fsetattrlist().
Fixes https://github.com/rfjakob/gocryptfs/issues/350
Diffstat (limited to 'internal/tlog/log.go')
0 files changed, 0 insertions, 0 deletions