summaryrefslogtreecommitdiff
path: root/internal/syscallcompat/open_nofollow_test.go
diff options
context:
space:
mode:
authorJakob Unterwurzacher2017-12-05 23:31:07 +0100
committerJakob Unterwurzacher2017-12-05 23:31:07 +0100
commit03bf604fc08abc9bb2d75bde21c96c9df4894a3b (patch)
tree3f96a2032ca78fd27f677d8833a6ad03d7598684 /internal/syscallcompat/open_nofollow_test.go
parent926cb93b50d6a573dbbef59ff841960b9d824c37 (diff)
syscallcompat: OpenNofollow: use O_DIRECTORY flag
...when opening intermedia directories to give us an extra layer of safety. From the FreeBSD man page: This flag can be used to prevent applications with elevated privileges from opening files which are even unsafe to open with O_RDONLY, such as device nodes.
Diffstat (limited to 'internal/syscallcompat/open_nofollow_test.go')
-rw-r--r--internal/syscallcompat/open_nofollow_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/internal/syscallcompat/open_nofollow_test.go b/internal/syscallcompat/open_nofollow_test.go
index 37ea76b..1f21557 100644
--- a/internal/syscallcompat/open_nofollow_test.go
+++ b/internal/syscallcompat/open_nofollow_test.go
@@ -31,8 +31,8 @@ func TestOpenNofollow(t *testing.T) {
if err == nil {
t.Fatalf("should have failed")
}
- if err != syscall.ELOOP {
- t.Errorf("expected ELOOP, got %v", err)
+ if err != syscall.ELOOP && err != syscall.ENOTDIR {
+ t.Errorf("expected ELOOP or ENOTDIR, got %v", err)
}
// Check to see that the base dir can be opened as well
fd, err = OpenNofollow(tmpDir, "", syscall.O_RDONLY, 0)