Fix all staticcheck errors in gocryptfs codebase

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Add staticcheck to test.bash for continuous static analysis

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Fix nil pointer dereference in timesToTimespec function

The previous fix for deprecated fuse.UtimeToTimespec caused a panic
because unix.TimeToTimespec doesn't handle nil pointers. This fix
properly handles nil pointers by using unix.UTIME_OMIT while still
using the non-deprecated unix.TimeToTimespec function.

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Undo SA6002 changes and add staticcheck ignore directive instead

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/internal/readpassword/read.go b/internal/readpassword/read.go
index 582a104..9193ae8 100644
--- a/internal/readpassword/read.go
+++ b/internal/readpassword/read.go
@@ -58,7 +58,7 @@ func Twice(extpass []string, passfile []string) ([]byte, error) {
 		return nil, err
 	}
 	if !bytes.Equal(p1, p2) {
-		return nil, fmt.Errorf("Passwords do not match")
+		return nil, fmt.Errorf("passwords do not match")
 	}
 	// Wipe the password duplicate from memory
 	for i := range p2 {
@@ -71,15 +71,15 @@ func Twice(extpass []string, passfile []string) ([]byte, error) {
 // Exits on read error or empty result.
 func readPasswordTerminal(prompt string) ([]byte, error) {
 	fd := int(os.Stdin.Fd())
-	fmt.Fprintf(os.Stderr, prompt)
+	fmt.Fprint(os.Stderr, prompt)
 	// term.ReadPassword removes the trailing newline
 	p, err := term.ReadPassword(fd)
 	if err != nil {
-		return nil, fmt.Errorf("Could not read password from terminal: %v\n", err)
+		return nil, fmt.Errorf("could not read password from terminal: %v", err)
 	}
 	fmt.Fprintf(os.Stderr, "\n")
 	if len(p) == 0 {
-		return nil, fmt.Errorf("Password is empty")
+		return nil, fmt.Errorf("password is empty")
 	}
 	return p, nil
 }
@@ -100,7 +100,7 @@ func readPasswordStdin(prompt string) ([]byte, error) {
 		return nil, err
 	}
 	if len(p) == 0 {
-		return nil, fmt.Errorf("Got empty %s from stdin", prompt)
+		return nil, fmt.Errorf("got empty %s from stdin", prompt)
 	}
 	return p, nil
 }