Fix all staticcheck errors in gocryptfs codebase

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Add staticcheck to test.bash for continuous static analysis

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Fix nil pointer dereference in timesToTimespec function

The previous fix for deprecated fuse.UtimeToTimespec caused a panic
because unix.TimeToTimespec doesn't handle nil pointers. This fix
properly handles nil pointers by using unix.UTIME_OMIT while still
using the non-deprecated unix.TimeToTimespec function.

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

Undo SA6002 changes and add staticcheck ignore directive instead

Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/internal/exitcodes/exitcodes.go b/internal/exitcodes/exitcodes.go
index 508ba38..881afda 100644
--- a/internal/exitcodes/exitcodes.go
+++ b/internal/exitcodes/exitcodes.go
@@ -3,7 +3,7 @@
 package exitcodes
 
 import (
-	"fmt"
+	"errors"
 	"os"
 )
 
@@ -83,7 +83,7 @@ type Err struct {
 // NewErr returns an error containing "msg" and the exit code "code".
 func NewErr(msg string, code int) Err {
 	return Err{
-		error: fmt.Errorf(msg),
+		error: errors.New(msg),
 		code:  code,
 	}
 }