diff options
| author | Jakob Unterwurzacher | 2019-04-08 20:18:45 +0200 |
|---|---|---|
| committer | Jakob Unterwurzacher | 2019-04-08 20:18:45 +0200 |
| commit | fe06e9f45646893dc88ebe9e657e2e991f6f5fbb (patch) | |
| tree | ad5d8e2910ed71a5c579e40f897093bec2e19011 /init_dir.go | |
| parent | 8459bb15c1a32561c250a8b688ab4a7ecda0a4aa (diff) | |
readpassword: delete CheckTrailingGarbage
CheckTrailingGarbage was called even when "-passfile" was
used, which is stupid, and causes false positives:
https://github.com/rfjakob/gocryptfs/issues/391
(false error "Received trailing garbage after the password"
when using -passfile in .bash_profile)
Instead of trying to improve the logic to handle that case
and make everything even more complicated, delete the function.
It is unclear if actually helps in some cases, and it definitely
harms as shown by the above bug report.
Diffstat (limited to 'init_dir.go')
| -rw-r--r-- | init_dir.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/init_dir.go b/init_dir.go index c3aa4b5..a9c66e3 100644 --- a/init_dir.go +++ b/init_dir.go @@ -81,7 +81,6 @@ func initDir(args *argContainer) { } else { // Normal password entry password = readpassword.Twice([]string(args.extpass), args.passfile) - readpassword.CheckTrailingGarbage() } creator := tlog.ProgramName + " " + GitVersion err = configfile.Create(args.config, password, args.plaintextnames, |