aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakob Unterwurzacher2016-12-10 15:01:00 +0100
committerJakob Unterwurzacher2016-12-10 15:01:00 +0100
commit8945f4db95ec75dd1f9de763ae249d9e433d3732 (patch)
tree4bd17019d34f74768b8bcd3389a7eb2e9f1a55f9
parent6af725ff099e78fab2920f060c127415aa3b1893 (diff)
ctlsock: add a note about Accept() throwing errors on Close()
-rw-r--r--internal/ctlsock/ctlsock_serve.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/internal/ctlsock/ctlsock_serve.go b/internal/ctlsock/ctlsock_serve.go
index 45b1e5b..a8e6766 100644
--- a/internal/ctlsock/ctlsock_serve.go
+++ b/internal/ctlsock/ctlsock_serve.go
@@ -60,6 +60,9 @@ func (ch *ctlSockHandler) acceptLoop() {
for {
conn, err := ch.socket.Accept()
if err != nil {
+ // TODO Can this warning trigger when the socket it closed on
+ // program exit? I have never observed it, but the documentation
+ // says that Close() unblocks Accept().
tlog.Warn.Printf("ctlsock: Accept error: %v", err)
break
}