Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.1 2021-08-18T13:48:01+00:00 2021-08-18T13:48:01+00:00 Jakob Unterwurzacher 2021-08-18T13:47:17+00:00 urn:sha1:64793fedf4ac8eebe05c57af75877944c60f03a4 gocryptfs$ ineffassign ./... /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:243:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:272:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:285:3: ineffectual assignment to fileID /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node.go:367:3: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node_open_create.go:68:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/mount.go:308:2: ineffectual assignment to masterkey /home/jakob/go/src/github.com/rfjakob/gocryptfs/gocryptfs-xray/xray_main.go:156:13: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/prepare_syscall_test.go:65:16: ineffectual assignment to errno /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/syscallcompat/open_nofollow_test.go:34:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:111:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:181:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:198:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:365:8: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:30:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:66:6: ineffectual assignment to err 2021-08-18T09:38:56+00:00 Jakob Unterwurzacher 2021-08-18T09:33:12+00:00 urn:sha1:0bc97845087b1e426d8cb2cb9c36779c4f9b2671 With test. Fixes https://github.com/rfjakob/gocryptfs/issues/588 2021-08-18T09:04:56+00:00 Jakob Unterwurzacher 2021-08-18T09:04:56+00:00 urn:sha1:3df1c624301bca215a300c2b9b9135c3966950f9 2021-08-18T09:04:40+00:00 Jakob Unterwurzacher 2021-08-18T08:56:45+00:00 urn:sha1:884398eec3a950ea5667aa8ddf63297b6a26b3da No functional changes. 2021-08-17T13:17:36+00:00 Jakob Unterwurzacher 2021-08-17T13:16:09+00:00 urn:sha1:b8ddc49eded4d6522cd30b99b773bab56d0f9fc3 Sometimes, by chance, case 5 resulted in valid decrypted data: --- FAIL: TestBadname (0.08s) cli_test.go:885: Case 5 failed: "J7Rbo1BvfXojpBEr0Qrt_invalid_file GOCRYPTFS_BAD_NAME" in ["file GOCRYPTFS_BAD_NAME,\x9e$O\xc3j\x8c\xd0\x06\x01#\f%k\x02\xcanvalid_file GOCRYPTFS_BAD_NAME,mzaZRF9_0IU-_5vv2wPC_invalid_file GOCRYPTFS_BAD_NAME,file,file_invalid_file GOCRYPTFS_BAD_NAME,mzaZRF9_0IU-_5vv2wP_invalid_file GOCRYPTFS_BAD_NAME"] Add percent signs so base64 decoding always fails. Fixes https://github.com/rfjakob/gocryptfs/runs/3347883728 2021-08-16T20:05:33+00:00 Jakob Unterwurzacher 2021-08-16T20:00:40+00:00 urn:sha1:eeb267950a111e4b5169a10ad723b14963667845 2021-08-16T17:24:04+00:00 Jakob Unterwurzacher 2021-08-16T17:24:04+00:00 urn:sha1:e2d3834b1c4aec2544369361f4b572c4f80dc544 https://github.com/kdave/btrfs-progs/issues/392 2021-08-16T17:23:58+00:00 Jakob Unterwurzacher 2021-08-16T16:40:48+00:00 urn:sha1:b2724070d95234a8cd281f275211e0f827a8bbe1 Fixes https://github.com/rfjakob/gocryptfs/issues/475 2021-08-16T15:15:07+00:00 Jakob Unterwurzacher 2021-08-16T15:15:07+00:00 urn:sha1:ad4b99170b9ad438909f5cba8c32109a18697a7a I just got this message (not reproducible) with unescaped binary garbage. UnmountErr: "/var/tmp/gocryptfs-test-parent-1026/114471933/TestMountBackground.899727687.mnt" was not found in MountInfo, cannot check for FD leaks UnmountErr: "/var/tmp/gocryptfs-test-parent-1026/114471933/TestConfigPipe.212912444.mnt" was not found in MountInfo, cannot check for FD leaks DecryptName "mzaZRF9_0IU-_5vv2wPC_i": unPad16 error: Padding too long, padLen=49 > 16 OpenDir ".": invalid entry "KqQ346cuOAFHv_qSta5PhAwrongPattern": bad message DecryptName "mzaZRF9_0IU-_5vv2wP_in": unPad16 error: Padding byte at i=10 is invalid --- FAIL: TestBadname (0.11s) cli_test.go:885: Case 5 failed: 'KqQ346cuOAFHv_qSta5P_invalid_file GOCRYPTFS_BAD_NAME' in [file_invalid_file GOCRYPTFS_BAD_NAME,file,mzaZRF9_0IU-_5vv2wPC_invalid_file GOCRYPTFS_BAD_NAME,file GOCRYPTFS_BAD_NAME,�*A���y���Gfnvalid_file GOCRYPTFS_BAD_NAME,mzaZRF9_0IU-_5vv2wP_invalid_file GOCRYPTFS_BAD_NAME] Invalid cipherdir: directory /var/tmp/gocryptfs-test-parent-1026/114471933/TestInitNotEmpty not empty FAIL FAIL github.com/rfjakob/gocryptfs/tests/cli 4.817s 2021-08-11T18:23:35+00:00 Jakob Unterwurzacher 2021-08-11T18:21:32+00:00 urn:sha1:2d386fc92e88be5384d1654db5d6e23ef4682354 We need to look at f_fstypename acc. to https://stackoverflow.com/a/52299141/1380267 : > As filesystem type numbers are now assigned at runtime in > recent versions of MacOS, you must use f_fstypename to > determine the type. https://github.com/rfjakob/gocryptfs/issues/585