Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.0 2021-06-02T12:29:48+00:00 2021-06-02T12:29:48+00:00 Jakob Unterwurzacher 2021-06-02T12:21:30+00:00 urn:sha1:04858ddd222bbf7156f33f99cfb293a9b1e15ec8 xfstests generic/523 discovered that we allowed to set xattrs with "/" in the name, but did not allow to read them later. With this change we do not allow to set them in the first place. 2021-05-29T14:56:20+00:00 Jakob Unterwurzacher 2021-05-29T14:56:20+00:00 urn:sha1:0e37fbe0425126c9dbb9a1816286e947d05a4b8e Failure looked like this: --- FAIL: TestFileHoleCopy (3.73s) --- FAIL: TestFileHoleCopy/k81 (0.04s) file_holes_test.go:93: size changed: st0.Blocks=88 st2.Blocks=96 file_holes_test.go:147: aborting further subtests $ findholes TestFileHoleCopy.k81.1 0 data 36864 hole 45056 data 50434 hole 50434 eof $ findholes TestFileHoleCopy.k81.2 0 data 36864 hole 45056 data 50434 hole 50434 eof $ filefrag -v TestFileHoleCopy.k81.1 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.1 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 23702311.. 23702313: 3: 1: 3.. 8: 20389855.. 20389860: 6: 23702314: 2: 11.. 12: 23702314.. 23702315: 2: 20389863: last,eof TestFileHoleCopy.k81.1: 3 extents found $ filefrag -v TestFileHoleCopy.k81.2 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.2 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 20389861.. 20389863: 3: 1: 3.. 4: 23702316.. 23702317: 2: 20389864: 2: 5.. 6: 20389864.. 20389865: 2: 23702318: 3: 7.. 8: 23702318.. 23702319: 2: 20389866: 4: 11.. 12: 23702320.. 23702321: 2: last,eof TestFileHoleCopy.k81.2: 4 extents found 2021-05-29T14:05:36+00:00 Jakob Unterwurzacher 2021-05-29T14:05:36+00:00 urn:sha1:738a9e006af6f5e43871c2d8e208601c18191965 In response to the discussion of the xfstests mailing list [1], I looked at the Lseek implementation, which was naive and did not handle all cases correctly. The new implementation aligns the returned values to 4096 bytes as most callers expect. A lot of tests are added to verify that we handle all cases correctly now. [1]: https://www.spinics.net/lists/fstests/msg16554.html 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-24T12:28:36+00:00 urn:sha1:9695f0e524aa2debd173d676a8fd56ad26603c5a Currently fails. 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-24T12:27:34+00:00 urn:sha1:629d0a5ad7307b4a3b5fb4b87c432a76ac256c1a Problem in go-fuse has long been fixed. 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-23T09:08:03+00:00 urn:sha1:7d72baca69825a83487728e000596241f4ac88fe As discovered by xfstests generic/401 [1], during the move to the v2 api we seem to have lost the "." and ".." directory entries. [1]: https://github.com/rfjakob/fuse-xfstests/blob/4ef5b032bc283743d0eb58a8a28738766e664899/screenlog.0#L520 2021-05-15T15:58:37+00:00 Jakob Unterwurzacher 2021-05-08T15:17:08+00:00 urn:sha1:86d8336b43418c028c34c37f06fcbd43ab0d44a1 With test to verify that it actually works this time: Run "make root_test". Depends-on: https://github.com/rfjakob/gocryptfs/issues/536 Fixes: https://github.com/rfjakob/gocryptfs/issues/536 2021-04-02T18:22:26+00:00 Jakob Unterwurzacher 2021-04-02T18:22:26+00:00 urn:sha1:beab7004f2556fec637ebe55a3aefad3d81c419f With 1.0 seconds we see failures on Travis, example: https://travis-ci.org/github/rfjakob/gocryptfs/builds/765648739 With 1.1 seconds it seems to always work. 2021-03-30T13:11:28+00:00 Jakob Unterwurzacher 2021-03-30T12:58:18+00:00 urn:sha1:a2effaae390253bfbc2e9522dd4b5123a067f60f 2021-03-21T10:10:18+00:00 Jakob Unterwurzacher 2021-03-21T10:10:18+00:00 urn:sha1:d7d79aa81c6d8f07e8b5c3f689b528462f32daa0 Towards better test coverage of shared backing storage mounts. https://github.com/rfjakob/gocryptfs/issues/525