Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=xattr_user_buffer 2025-07-08T17:54:14+00:00 2025-07-08T17:54:14+00:00 copilot-swe-agent[bot] 2025-07-07T18:18:12+00:00 urn:sha1:386232f39ede046d6453a0990ad40f2d86a26f53 Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com> Add staticcheck to test.bash for continuous static analysis Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com> Fix nil pointer dereference in timesToTimespec function The previous fix for deprecated fuse.UtimeToTimespec caused a panic because unix.TimeToTimespec doesn't handle nil pointers. This fix properly handles nil pointers by using unix.UTIME_OMIT while still using the non-deprecated unix.TimeToTimespec function. Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com> Undo SA6002 changes and add staticcheck ignore directive instead Co-authored-by: rfjakob <286847+rfjakob@users.noreply.github.com> 2025-07-07T17:59:35+00:00 Jakob Unterwurzacher 2025-07-07T17:54:48+00:00 urn:sha1:8f5df19b353e02ffba842fd1b15ccf93da7ee3b4 Tool-assisted. 2022-08-28T09:11:36+00:00 Jakob Unterwurzacher 2022-08-28T09:11:36+00:00 urn:sha1:003a7fa2e53ac15d2c94a34102ae12b69b23c586 2021-12-19T13:43:56+00:00 Jakob Unterwurzacher 2021-12-19T13:43:56+00:00 urn:sha1:64be5de75f42e415198ff5e77de509680b69e0e1 xattr names have fewer restrictions than file names, relax the validation. Fixes https://github.com/rfjakob/gocryptfs/issues/627 2021-08-23T13:05:15+00:00 Jakob Unterwurzacher 2021-08-23T13:05:15+00:00 urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858 Our git version is v2+ for some time now, but go.mod still declared v1. Hopefully making both match makes https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work. All the import paths have been fixed like this: find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/% 2021-08-18T13:48:01+00:00 Jakob Unterwurzacher 2021-08-18T13:47:17+00:00 urn:sha1:64793fedf4ac8eebe05c57af75877944c60f03a4 gocryptfs$ ineffassign ./... /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:243:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:272:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:285:3: ineffectual assignment to fileID /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node.go:367:3: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node_open_create.go:68:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/mount.go:308:2: ineffectual assignment to masterkey /home/jakob/go/src/github.com/rfjakob/gocryptfs/gocryptfs-xray/xray_main.go:156:13: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/prepare_syscall_test.go:65:16: ineffectual assignment to errno /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/syscallcompat/open_nofollow_test.go:34:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:111:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:181:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:198:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:365:8: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:30:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:66:6: ineffectual assignment to err 2021-02-07T19:00:33+00:00 Jakob Unterwurzacher 2021-02-07T19:00:33+00:00 urn:sha1:bb2484f1520102f4ab6c84400f9eef53d4cdd2ad The blob was truncated to 31 bytes. 2020-07-12T11:40:21+00:00 Jakob Unterwurzacher 2020-07-12T11:40:21+00:00 urn:sha1:fd0e8aa869ec74917d669d42f0e0d3b2888237b9 2020-02-29T19:38:48+00:00 Jakob Unterwurzacher 2020-02-29T19:38:48+00:00 urn:sha1:fdfaa849f8ea2fc6687aa13a7057b5088e3c65e5 Fixes https://github.com/rfjakob/gocryptfs/issues/453 2019-10-06T19:53:20+00:00 Jakob Unterwurzacher 2019-10-06T19:50:27+00:00 urn:sha1:8c4429408716d9890a98a48c246d616dbfea7e31 On Fedora, /tmp is tmpfs, which behaves differently than ext4 (inode numbers are never reused, for example). Use /var/tmp, which is ext4 on Fedora, to get a more realistic test environment. This also allows us to drop the xattr workaround.