Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.5.1 2023-05-17T13:21:20+00:00 2023-05-17T13:21:20+00:00 Jakob Unterwurzacher 2023-05-17T13:20:20+00:00 urn:sha1:76d0f3ca7c491b39197e1a69c52b63c39455acfc Otherwise we fail like this on my Fedora 38 box: === RUN TestOverlay DetectQuirks: tmpfs detected, no extended attributes except acls will work. root_test.go:379: No user xattrs! overlay mount will likely fail. 15:15:57.957960 Unimplemented opcode OPCODE-51 root_test.go:398: mount: /tmp/gocryptfs-test-parent-0/3652394902/TestOverlay.2374697046.mnt/merged: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error. dmesg(1) may have more information after failed mount system call. root_test.go:399: exit status 32 --- FAIL: TestOverlay (0.04s) FAIL Also fix the messed-up DetectQuirks bit test. 2022-08-28T09:11:36+00:00 Jakob Unterwurzacher 2022-08-28T09:11:36+00:00 urn:sha1:003a7fa2e53ac15d2c94a34102ae12b69b23c586 2022-01-27T17:36:51+00:00 Jakob Unterwurzacher 2022-01-27T17:35:45+00:00 urn:sha1:a2b54cfccd7d67529f87309c84ab7c00a8b6a4b0 After running "make root_test" a few times df would look like this, no good: $ df Filesystem 1K-blocks Used Available Use% Mounted on [...] /dev/loop11 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/4081611019/TestDiskFull.ext4.mnt /dev/loop12 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/1959939106/TestDiskFull.ext4.mnt /dev/loop13 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/2455888382/TestDiskFull.ext4.mnt /dev/loop14 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/2002998275/TestDiskFull.ext4.mnt /dev/loop15 8729 8525 0 100% /var/tmp/gocryptfs-test-parent-0/806736609/TestDiskFull.ext4.mnt /dev/loop16 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/4050106930/TestDiskFull.ext4.mnt /dev/loop17 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/1661931756/TestDiskFull.ext4.mnt /dev/loop18 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/617990718/TestDiskFull.ext4.mnt /dev/loop19 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/3194420338/TestDiskFull.ext4.mnt /dev/loop20 8729 8525 0 100% /tmp/gocryptfs-test-parent-0/2180745159/TestDiskFull.ext4.mnt Turns out the unmount failed with EBUSY, so use lazy unmount. 2022-01-27T14:44:09+00:00 Jakob Unterwurzacher 2022-01-27T14:44:09+00:00 urn:sha1:ba75aa1ab0dcef8ad8c8fbb11e8895413ad26787 2021-12-08T17:50:42+00:00 Jakob Unterwurzacher 2021-12-08T17:50:42+00:00 urn:sha1:ec186c13cebeea48112aa9a863c278ffc23db197 This does not work neither make sense on MacOS. 2021-12-08T17:49:21+00:00 Jakob Unterwurzacher 2021-12-08T17:49:21+00:00 urn:sha1:7d60315cd53080e223051a4f16eb3ace3b86e095 Creat() is equivalent to Open(..., O_CREAT|O_WRONLY|O_TRUNC, ...) and MacOS does not have syscall.Creat(). https://github.com/rfjakob/gocryptfs/issues/623 2021-08-23T13:05:15+00:00 Jakob Unterwurzacher 2021-08-23T13:05:15+00:00 urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858 Our git version is v2+ for some time now, but go.mod still declared v1. Hopefully making both match makes https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work. All the import paths have been fixed like this: find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/% 2021-08-19T06:34:49+00:00 Jakob Unterwurzacher 2021-08-19T06:00:44+00:00 urn:sha1:8ee595dd484919b98bd9908900fbece2585a334d Issues were: # github.com/rfjakob/gocryptfs/contrib/findholes/holes contrib/findholes/holes/holes.go:136:2: unreachable code # github.com/rfjakob/gocryptfs/tests/root_test_test tests/root_test/root_test.go:139:2: unreachable code Also make sure we actually run "go vet" against the whole codebase. 2021-08-16T17:24:04+00:00 Jakob Unterwurzacher 2021-08-16T17:24:04+00:00 urn:sha1:e2d3834b1c4aec2544369361f4b572c4f80dc544 https://github.com/kdave/btrfs-progs/issues/392 2021-08-11T18:23:35+00:00 Jakob Unterwurzacher 2021-08-11T18:21:32+00:00 urn:sha1:2d386fc92e88be5384d1654db5d6e23ef4682354 We need to look at f_fstypename acc. to https://stackoverflow.com/a/52299141/1380267 : > As filesystem type numbers are now assigned at runtime in > recent versions of MacOS, you must use f_fstypename to > determine the type. https://github.com/rfjakob/gocryptfs/issues/585