Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=xattr_user_buffer 2025-12-14T10:39:31+00:00 2025-12-14T10:39:31+00:00 Jakob Unterwurzacher 2025-12-14T10:38:45+00:00 urn:sha1:745276fe6e2b81570e5c84625699d632da5fd6a9 $ staticcheck --version staticcheck 2025.1.1 (0.6.1) $ staticcheck ./... contrib/findholes/holes/holes.go:179:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019) tests/defaults/acl_test.go:24:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019) tests/plaintextnames/file_holes_test.go:143:2: rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. (SA1019) 2025-07-07T17:59:35+00:00 Jakob Unterwurzacher 2025-07-07T17:54:48+00:00 urn:sha1:8f5df19b353e02ffba842fd1b15ccf93da7ee3b4 Tool-assisted. 2025-01-18T13:27:27+00:00 Jakob Unterwurzacher 2025-01-18T13:27:27+00:00 urn:sha1:38936cba4e319525875feaa5d44b85819692e056 This problem potentially causes extra disk usage for sparse files but is otherwise harmless. Skip the test for now. 2024-11-11T21:33:07+00:00 Jakob Unterwurzacher 2024-11-11T21:27:42+00:00 urn:sha1:86891054ef2a5d1b0b59c7c140aae284e7c5bd87 Now that https://github.com/hanwen/go-fuse/issues/399 has landed we can report an inode number for the root node. Fixes https://github.com/rfjakob/gocryptfs/issues/580 2022-12-29T14:00:37+00:00 Jakob Unterwurzacher 2022-12-29T14:00:24+00:00 urn:sha1:856ccaac10579abda5620dfc86ad6031b1076a43 Run "make format" using go version go1.19.4 linux/amd64 2021-12-08T17:49:21+00:00 Jakob Unterwurzacher 2021-12-08T17:49:21+00:00 urn:sha1:7d60315cd53080e223051a4f16eb3ace3b86e095 Creat() is equivalent to Open(..., O_CREAT|O_WRONLY|O_TRUNC, ...) and MacOS does not have syscall.Creat(). https://github.com/rfjakob/gocryptfs/issues/623 2021-08-23T13:05:15+00:00 Jakob Unterwurzacher 2021-08-23T13:05:15+00:00 urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858 Our git version is v2+ for some time now, but go.mod still declared v1. Hopefully making both match makes https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work. All the import paths have been fixed like this: find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/% 2021-05-29T14:56:20+00:00 Jakob Unterwurzacher 2021-05-29T14:56:20+00:00 urn:sha1:0e37fbe0425126c9dbb9a1816286e947d05a4b8e Failure looked like this: --- FAIL: TestFileHoleCopy (3.73s) --- FAIL: TestFileHoleCopy/k81 (0.04s) file_holes_test.go:93: size changed: st0.Blocks=88 st2.Blocks=96 file_holes_test.go:147: aborting further subtests $ findholes TestFileHoleCopy.k81.1 0 data 36864 hole 45056 data 50434 hole 50434 eof $ findholes TestFileHoleCopy.k81.2 0 data 36864 hole 45056 data 50434 hole 50434 eof $ filefrag -v TestFileHoleCopy.k81.1 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.1 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 23702311.. 23702313: 3: 1: 3.. 8: 20389855.. 20389860: 6: 23702314: 2: 11.. 12: 23702314.. 23702315: 2: 20389863: last,eof TestFileHoleCopy.k81.1: 3 extents found $ filefrag -v TestFileHoleCopy.k81.2 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.2 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 20389861.. 20389863: 3: 1: 3.. 4: 23702316.. 23702317: 2: 20389864: 2: 5.. 6: 20389864.. 20389865: 2: 23702318: 3: 7.. 8: 23702318.. 23702319: 2: 20389866: 4: 11.. 12: 23702320.. 23702321: 2: last,eof TestFileHoleCopy.k81.2: 4 extents found 2021-05-29T14:05:36+00:00 Jakob Unterwurzacher 2021-05-29T14:05:36+00:00 urn:sha1:738a9e006af6f5e43871c2d8e208601c18191965 In response to the discussion of the xfstests mailing list [1], I looked at the Lseek implementation, which was naive and did not handle all cases correctly. The new implementation aligns the returned values to 4096 bytes as most callers expect. A lot of tests are added to verify that we handle all cases correctly now. [1]: https://www.spinics.net/lists/fstests/msg16554.html 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-24T12:28:36+00:00 urn:sha1:9695f0e524aa2debd173d676a8fd56ad26603c5a Currently fails.