Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.1 2021-05-29T14:56:20+00:00 2021-05-29T14:56:20+00:00 Jakob Unterwurzacher 2021-05-29T14:56:20+00:00 urn:sha1:0e37fbe0425126c9dbb9a1816286e947d05a4b8e Failure looked like this: --- FAIL: TestFileHoleCopy (3.73s) --- FAIL: TestFileHoleCopy/k81 (0.04s) file_holes_test.go:93: size changed: st0.Blocks=88 st2.Blocks=96 file_holes_test.go:147: aborting further subtests $ findholes TestFileHoleCopy.k81.1 0 data 36864 hole 45056 data 50434 hole 50434 eof $ findholes TestFileHoleCopy.k81.2 0 data 36864 hole 45056 data 50434 hole 50434 eof $ filefrag -v TestFileHoleCopy.k81.1 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.1 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 23702311.. 23702313: 3: 1: 3.. 8: 20389855.. 20389860: 6: 23702314: 2: 11.. 12: 23702314.. 23702315: 2: 20389863: last,eof TestFileHoleCopy.k81.1: 3 extents found $ filefrag -v TestFileHoleCopy.k81.2 Filesystem type is: ef53 File size of TestFileHoleCopy.k81.2 is 50434 (13 blocks of 4096 bytes) ext: logical_offset: physical_offset: length: expected: flags: 0: 0.. 2: 20389861.. 20389863: 3: 1: 3.. 4: 23702316.. 23702317: 2: 20389864: 2: 5.. 6: 20389864.. 20389865: 2: 23702318: 3: 7.. 8: 23702318.. 23702319: 2: 20389866: 4: 11.. 12: 23702320.. 23702321: 2: last,eof TestFileHoleCopy.k81.2: 4 extents found 2021-05-29T14:05:36+00:00 Jakob Unterwurzacher 2021-05-29T14:05:36+00:00 urn:sha1:738a9e006af6f5e43871c2d8e208601c18191965 In response to the discussion of the xfstests mailing list [1], I looked at the Lseek implementation, which was naive and did not handle all cases correctly. The new implementation aligns the returned values to 4096 bytes as most callers expect. A lot of tests are added to verify that we handle all cases correctly now. [1]: https://www.spinics.net/lists/fstests/msg16554.html 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-24T12:28:36+00:00 urn:sha1:9695f0e524aa2debd173d676a8fd56ad26603c5a Currently fails. 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-24T12:27:34+00:00 urn:sha1:629d0a5ad7307b4a3b5fb4b87c432a76ac256c1a Problem in go-fuse has long been fixed. 2020-09-12T15:55:37+00:00 Jakob Unterwurzacher 2020-09-12T15:54:55+00:00 urn:sha1:6a9c49e9cf23c85622dd4b181cdc615abc72d6bb 2018-09-08T10:40:29+00:00 Jakob Unterwurzacher 2018-09-08T10:40:29+00:00 urn:sha1:2bdf7d5172d3540606f098030e8ede7a3ad1dfdd Callers that do not want to decrypt the masterkey should call plain Load(). https://github.com/rfjakob/gocryptfs/issues/258 2018-07-01T18:56:22+00:00 Jakob Unterwurzacher 2018-06-25T20:02:05+00:00 urn:sha1:91de77943fba3cb993aad4e9756e159c4514764a configfile.LoadConfFile() -> configfile.Load() configfile.CreateConfFile() -> configfile.Create() 2018-02-18T13:26:54+00:00 Jakob Unterwurzacher 2018-02-18T13:26:54+00:00 urn:sha1:3b8f5cbb17c964224456bb36b096feafb0e24f44 This will allows us to overwrite the password with zeros once we are done with it. https://github.com/rfjakob/gocryptfs/issues/211 2016-10-24T17:18:13+00:00 Jakob Unterwurzacher 2016-10-24T17:18:13+00:00 urn:sha1:aeda9721d0150b9b77d9522bb3b4fcd17f2cbbfa Close https://github.com/rfjakob/gocryptfs/issues/54 2016-07-11T18:41:16+00:00 Jakob Unterwurzacher 2016-07-11T18:31:36+00:00 urn:sha1:1c54fcd04bbf274dd5d4300e433bdcb1bb32e1ce This should make it work on OSX. Also, split unmount into two functions. Depending on what you want, * UnmountErr returns the resulting error * UnmountPanic panics if the error was not nil