Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.0.1 2021-06-06T17:22:16+00:00 2021-06-06T17:22:16+00:00 Jakob Unterwurzacher 2021-06-06T17:22:16+00:00 urn:sha1:17f859d3c409bf2730a47d56979c0700171006b7 gocryptfs 2.0 introduced the regression that the size reported at symlink creation was the ciphertext size, which is wrong. Report the plaintext size. Fixes https://github.com/rfjakob/gocryptfs/issues/574 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-23T09:08:03+00:00 urn:sha1:7d72baca69825a83487728e000596241f4ac88fe As discovered by xfstests generic/401 [1], during the move to the v2 api we seem to have lost the "." and ".." directory entries. [1]: https://github.com/rfjakob/fuse-xfstests/blob/4ef5b032bc283743d0eb58a8a28738766e664899/screenlog.0#L520 2021-03-20T17:27:34+00:00 Jakob Unterwurzacher 2021-03-20T17:27:34+00:00 urn:sha1:692a79461a7b0f60625ecf8b1a136bc6595f1273 Currently fails like this: === RUN TestRmwRace doRead 0: corrupt block #0: cipher: message authentication failed -wpanic turns this warning into a panic: doRead 0: corrupt block #0: cipher: message authentication failed panic: -wpanic turns this warning into a panic: doRead 0: corrupt block #0: cipher: message authentication failed goroutine 1293 [running]: log.(*Logger).Panic(0xc00011c230, 0xc0003b17c8, 0x1, 0x1) log/log.go:224 +0xac github.com/rfjakob/gocryptfs/internal/tlog.(*toggledLogger).Printf(0xc00007a780, 0x55a821a766a1, 0x20, 0xc0003b19f0, 0x3, 0x3) github.com/rfjakob/gocryptfs/internal/tlog/log.go:78 +0x1ef github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).doRead(0xc0001ff420, 0x0, 0x0, 0x0, 0x0, 0x1000, 0x0, 0x1, 0xc000880000, 0x1020) github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:201 +0x8c9 github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).doWrite(0xc0001ff420, 0xc000248428, 0x10, 0x30, 0xff0, 0x3, 0x18) github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:291 +0xc9e github.com/rfjakob/gocryptfs/internal/fusefrontend.(*File).Write(0xc0001ff420, 0x55a821b306a0, 0xc000fbde90, 0xc000248428, 0x10, 0x30, 0xff0, 0x7f4a00000000, 0x0) github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:378 +0x25e github.com/hanwen/go-fuse/v2/fs.(*rawBridge).Write(0xc000168140, 0xc000096000, 0xc0002483d8, 0xc000248428, 0x10, 0x30, 0x55a821ad40e0) github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fs/bridge.go:819 +0x26d github.com/hanwen/go-fuse/v2/fuse.doWrite(0xc000170160, 0xc000248240) github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/opcode.go:191 +0x6f github.com/hanwen/go-fuse/v2/fuse.(*Server).handleRequest(0xc000170160, 0xc000248240, 0xc000000000) github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:472 +0x2be github.com/hanwen/go-fuse/v2/fuse.(*Server).loop(0xc000170160, 0xc000cd4101) github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:445 +0x198 created by github.com/hanwen/go-fuse/v2/fuse.(*Server).readRequest github.com/hanwen/go-fuse/v2@v2.0.4-0.20210125162859-8e0bbdb16cb7/fuse/server.go:312 +0x41d matrix_test.go:354: Write failed 2020-09-09T16:18:37+00:00 Jakob Unterwurzacher 2020-09-09T16:18:37+00:00 urn:sha1:db61ec5115f6d2ae0e9dfcf2b87163221a969f6b 2020-08-16T17:41:00+00:00 Jakob Unterwurzacher 2020-08-16T17:41:00+00:00 urn:sha1:58a2726977a1b1f92063a1e51c0769af71833e72 2020-08-15T13:39:08+00:00 Jakob Unterwurzacher 2020-08-15T13:39:08+00:00 urn:sha1:f270135c1614843f43a9df0e68b6e3fa556b6774 Instead bubble up the error to the testing object. 2020-07-12T19:00:52+00:00 Jakob Unterwurzacher 2020-07-12T18:58:38+00:00 urn:sha1:d7db071528cff2450fd766bb48d0303444f18bf5 Chasing a bug that seems to have nothing to do with magic names, as it already triggers during warmup: --- FAIL: TestMagicNames (0.00s) matrix_test.go:773: Testing n="warmup1" matrix_test.go:773: Testing n="warmup2" matrix_test.go:820: no such file or directory 2020-07-12T13:08:17+00:00 Jakob Unterwurzacher 2020-07-12T13:08:17+00:00 urn:sha1:f11432d02ab8fce306ba85e735b7c3db085f9da6 2020-05-09T22:25:49+00:00 Jakob Unterwurzacher 2020-05-09T22:25:49+00:00 urn:sha1:ead7008a08f9ace4591ebbc03e63fdc7ef37e502 https://github.com/client9/misspell 2020-05-09T13:42:57+00:00 Jakob Unterwurzacher 2020-05-09T13:42:57+00:00 urn:sha1:c19baa10f8e8365ed9e3212a003a6b8f31f0320a We did not use t.Name() as it was not available before Go 1.8. Now the oldest Go version we support is Go 1.11, so we can use it.