Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7.1 2019-03-03T13:09:33+00:00 2019-03-03T13:09:33+00:00 Jakob Unterwurzacher 2019-03-03T13:09:33+00:00 urn:sha1:cd7a6862116dc3bac11d2a67fe93f20a7afc7284 Ironically, the test for DirIV races had a data race itself by writing to a bool without taking a lock. Found by running "./test.bash -race": WARNING: DATA RACE Write at 0x00c00001dea5 by goroutine 22: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func1() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:39 +0x38 github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:73 +0x65c testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 Previous read at 0x00c00001dea5 by goroutine 23: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func2() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:51 +0x8b Goroutine 22 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:916 +0x699 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1157 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 testing.runTests() /usr/local/go/src/testing/testing.go:1155 +0x523 testing.(*M).Run() /usr/local/go/src/testing/testing.go:1072 +0x2eb github.com/rfjakob/gocryptfs/tests/defaults.TestMain() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:21 +0xe1 main.main() _testmain.go:76 +0x222 Goroutine 23 (running) created at: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:43 +0x48d testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 ================== --- FAIL: TestDirIVRace (0.00s) testing.go:809: race detected during execution of test FAIL 2019-01-20T16:20:30+00:00 Jakob Unterwurzacher 2019-01-20T16:20:30+00:00 urn:sha1:da3ba5e7f5efb164acb1292dd85b4fe25dd8e3bf https://github.com/rfjakob/gocryptfs/issues/349 2019-01-02T00:09:09+00:00 Jakob Unterwurzacher 2019-01-02T00:09:09+00:00 urn:sha1:772afa93f98aa77959995e42564b898057c59b87 Give the gocryptfs process one extra millisecond to close files. Allows us to drop several other sleeps. UnmountErr now really returns an error when it detects an fd leak instead of just printing a message. 2019-01-01T21:01:49+00:00 Jakob Unterwurzacher 2019-01-01T21:01:49+00:00 urn:sha1:10de105c13e4ef512fe83b8c1074fc453f3e70ff For now, this only prints a message but does not fail the tests. 2018-12-27T14:19:55+00:00 Sebastian Lackner 2018-12-27T11:03:00+00:00 urn:sha1:874eaf9734cc10940e08f7b043652449e1e220b5 Mostly detected with the 'codespell' utility, but also includes some manual grammar fixes. 2018-05-17T21:14:33+00:00 Jakob Unterwurzacher 2018-05-17T21:14:33+00:00 urn:sha1:44caf21debd445623fb481827fae6fc8a5eb911d This currently fails because we do not use llistxattr yet. 2018-05-15T21:00:47+00:00 Jakob Unterwurzacher 2018-05-15T21:00:47+00:00 urn:sha1:7b0068180772b9dd7e0b00ca9e1b0f3ce39c9c23 mv is unhappy when we return EPERM when it tries to set system.posix_acl_access: mv: preserving permissions for ‘b/x’: Operation not permitted Now we return EOPNOTSUPP like tmpfs does and mv seems happy. 2018-04-02T16:32:30+00:00 Jakob Unterwurzacher 2018-04-02T16:32:30+00:00 urn:sha1:b6c8960b01f9e5366814b0dada57a0b1e6a031d9 Make sure we get only 1 warning output per problem. Also, add new corruption types to broken_fs_v1.4. 2018-03-05T21:00:59+00:00 Jakob Unterwurzacher 2018-03-05T20:56:30+00:00 urn:sha1:3064d72b9774029ab89daea8a7fccfe181c3cae0 We relied on the finalizer to close a few fds. For some reason, this did not cause problems on Linux, but on MacOS, it causes unmount failures: umount(/private/tmp/gocryptfs-test-parent/194654785/default-plain): Resource busy -- try 'diskutil unmount' 2017-08-10T19:01:19+00:00 Jakob Unterwurzacher 2017-08-10T18:55:45+00:00 urn:sha1:f59479736bed49411bda3368f419d6605f1faa78 Passes.