Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=LockSharedStorage_rebase2 2026-07-16T19:20:29+00:00 2026-07-16T19:20:29+00:00 Jakob Unterwurzacher 2026-07-16T19:16:45+00:00 urn:sha1:835cd40733d63bce9a4bd843482766c246495044 2026-07-16T19:01:01+00:00 Jakob Unterwurzacher 2026-07-16T19:01:01+00:00 urn:sha1:6a098702f11f1c2c9f5a3d102c56c3b9232719eb ...and one typo. 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-09T12:35:04+00:00 urn:sha1:a00736332c836dbb6b87f6132513f1cac5407e0b Add the -sharedstorage flag to the mounts and make it more severe by adjusting the I/O and file sizes to arbitrary unaligned values. It passes *most of the time*. If it fails, it's like this, and the reason is that there is no fcntl locks in the READ path yet. gocryptfs/tests/cluster$ go test -run TestClusterConcurrentRW -v === RUN TestClusterConcurrentRW doRead 2895433: corrupt block #0: cipher: message authentication failed doRead 2895433: corrupt block #0: cipher: message authentication failed doRead 2895433: corrupt block #0: cipher: message authentication failed cluster_test.go:98: readThread iteration 9165: ReadAt failed: read /var/tmp/gocryptfs-test-parent-1026/3021427391/TestClusterConcurrentRW.366469887.mnt1/foo: input/output error --- FAIL: TestClusterConcurrentRW (0.40s) FAIL exit status 1 FAIL github.com/rfjakob/gocryptfs/v2/tests/cluster 0.406s 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-09T12:33:07+00:00 urn:sha1:0df7f624c82c23049f8c404e5235b44fe174efcb 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-09T05:50:11+00:00 urn:sha1:69cb943fa6b313b0d19668c92a4bcceed62fa561 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-08T13:50:05+00:00 urn:sha1:11cae523c9758fabe7ed1a24aaccf82d461dafb0 Scary. But explains why TestConcurrentCreate fails. gocryptfs/tests/cluster$ go test -run TestPoCTornWrite --- FAIL: TestPoCTornWrite (0.00s) poc_test.go:210: iteration 214: inconsistent block: d6d6d6d6d6d6d6d6d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1d1 FAIL 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-05T11:43:23+00:00 urn:sha1:10154a07f24998a04f5225d8125218194f9b2d76 This fails right now: 1 jakob@brikett:~/go/src/github.com/rfjakob/gocryptfs/tests/cluster$ go test -run TestOpenTruncate -v === RUN TestOpenTruncate cluster_test.go:235: POSIX compliance issue: non-exlusive create failed with err=file exists doWrite 2898550: corrupt header: ParseHeader: header is all-zero. Header hexdump: 000000000000000000000000000000000000 cluster_test.go:240: iteration 1: WriteAt: write /var/tmp/gocryptfs-test-parent-1026/1896094179/TestOpenTruncate.4202105280.mnt2/foo: input/output error --- FAIL: TestOpenTruncate (0.10s) FAIL exit status 1 FAIL github.com/rfjakob/gocryptfs/v2/tests/cluster 0.099s 1 jakob@brikett:~/go/src/github.com/rfjakob/gocryptfs/tests/cluster$ go test -run TestOpenTruncate -v === RUN TestOpenTruncate cluster_test.go:235: POSIX compliance issue: non-exlusive create failed with err=file exists doRead 2898565: corrupt block #0: cipher: message authentication failed ino2898565 fh9: RMW read failed: errno=5 cluster_test.go:240: iteration 8: WriteAt: write /var/tmp/gocryptfs-test-parent-1026/652691834/TestOpenTruncate.281532388.mnt1/foo: input/output error --- FAIL: TestOpenTruncate (0.09s) FAIL exit status 1 FAIL github.com/rfjakob/gocryptfs/v2/tests/cluster 0.095s 2026-07-16T18:10:19+00:00 Jakob Unterwurzacher 2023-06-05T11:28:11+00:00 urn:sha1:a860b86b00652ac50b8bf23f9e783322ba39c67b 2026-07-16T17:56:58+00:00 Jakob Unterwurzacher 2023-06-05T10:42:33+00:00 urn:sha1:0b8e9be5ec3bf16c17b2d53a3c8d62e8f525331e This exercises the byte-range locks we just added. 2026-07-16T17:56:48+00:00 Jakob Unterwurzacher 2023-06-02T12:24:44+00:00 urn:sha1:e56c2e44cc4dd1484cae78956f8ff72a9eea42f2 Multiple host writing to the same empty file at the same time could have overwritten each other's newly created file header, leading to data corruption. Fix the race by placing a byte-range lock on the file when creating the file header.