gocryptfs/internal, branch v1.4.4 Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.4.4 2018-03-05T22:40:08+00:00 macos: tests: fix deleting of scratch dir 2018-03-05T22:40:08+00:00 Jakob Unterwurzacher 2018-03-05T22:40:08+00:00 urn:sha1:4732e33a9a39935ecc07dfb7e857cc05b6fc6045 macos rm does not understand --one-file-system, and it cannot handle unreadable directories. macos: fix second TestEmulateSymlinkat test failure 2018-03-05T20:20:07+00:00 Jakob Unterwurzacher 2018-03-05T20:20:07+00:00 urn:sha1:7db5395c5346a1b32656b27e504417779435edc8 MacOS: don't test symlinks longer than 1000 bytes 2018-02-28T19:40:08+00:00 Jakob Unterwurzacher 2018-02-28T19:40:08+00:00 urn:sha1:c5243fc79e25cd589e78f47dafe0e8144885e6e4 The limit is much lower than on Linux. https://github.com/rfjakob/gocryptfs/issues/213 MacOS: fix TestEmulateSymlinkat test failure 2018-02-28T19:19:31+00:00 Jakob Unterwurzacher 2018-02-28T19:19:31+00:00 urn:sha1:90f2fea7fba8cd2cab1c28471f955a99f91ca0ad On MacOS, symlinks don't have their own permissions, so don't check for them. tlog: stop embedding log.Logger to prevent mistakes 2018-02-28T08:02:18+00:00 Jakob Unterwurzacher 2018-02-28T08:02:18+00:00 urn:sha1:b96e3ee2717531e842c492c3a6799d1d0c3e51cb A few places have called tlog.Warn.Print, which directly calls into log.Logger due to embedding, losing all features of tlog. Stop embedding log.Logger to make sure the internal functions cannot be called accidentially and fix (several!) instances that did. ctlsock: don't Warn() on closed socket 2018-02-27T08:58:14+00:00 Jakob Unterwurzacher 2018-02-27T08:58:14+00:00 urn:sha1:db45f2767187a44227fe8bd4c680cdcbd53cc489 This Warn() is causing panics in the test suite on MacOS: https://github.com/rfjakob/gocryptfs/issues/213 cryptocore: make AEADTypeEnum values explicit 2018-02-18T15:20:38+00:00 Jakob Unterwurzacher 2018-02-18T15:20:38+00:00 urn:sha1:5ad9bda206e476fea866907e2f0545257f74e1f0 We now print the number in a debug message, so define the numeric values explicitely instead of using iota. This way you don't have to understand how iota works to find out what the number means. Lack of understanding of how iota works is also the reason why the numbers start at 3 (to keep the current behavoir). cryptocore: zero derived keys 2018-02-18T15:07:09+00:00 Jakob Unterwurzacher 2018-02-18T15:07:09+00:00 urn:sha1:6c6947126d38f8988bcbf59db088c9cddc55b9ab Zero the HKDF-derived keys when we don't need them anymore, and let the variable run of of scope. https://github.com/rfjakob/gocryptfs/issues/211 siv_aead: create private key copy and implement wiping 2018-02-18T15:01:46+00:00 Jakob Unterwurzacher 2018-02-18T15:01:46+00:00 urn:sha1:344d7e0a6f06cf7829dc5af1732dfbd116597dc1 Having a private copy relieves the caller from worrying about whether he can zero his copy. The copy can be cleared by calling Wipe(). main: changePassword: zero masterkey 2018-02-18T14:36:14+00:00 Jakob Unterwurzacher 2018-02-18T14:33:35+00:00 urn:sha1:adf7d75d31889e2dbd52c15efdecf3a8304c0bc1 Overwrite the masterkey with zeros once we have encrypted it, and let it run out of scope. Also get rid of the password duplicate in readpassword.Twice.