gocryptfs/internal, branch v0.11

fusefrontend: Utimens: convert ENOENT to EBADF

2016-06-09T20:21:00+00:00

If /proc/self/fd/X did not exist, the actual error is that the file descriptor was invalid. go-fuse's pathfs prefers using an open fd even for path-based operations but does not take any locks to prevent the fd from being closed. Instead, it retries the operation by path if it get EBADF. So this change allows the retry logic to work correctly. This fixes the error rsync: failed to set times on "/tmp/ping.Kgw.mnt/linux-3.0/[...]/.dvb_demux.c.N7YlEM": No such file or directory (2) that was triggered by pingpong-rsync.bash.

fusefrontend: fix chown on dangling symlinks

2016-06-07T22:32:44+00:00

We (actually, go-fuse) used to call Chown() instead of Lchown() which meant that the operation would fail on dangling symlinks. Fix this by calling os.Lchown() ourself. Also add a test case for this.

configfile: warn about missing feature flags

2016-06-06T21:13:10+00:00

The plan is to drop support for the oldest filesystem versions in gocryptfs v1.0. For now, we only warn the user.

toggledlog: convert remaing naked fmt.Print*

2016-06-05T12:32:07+00:00

Several fatal errors were just printed to stdout, which meant they were invisible when running the test suite. Fix this by introducing toggledlog.Fatal and convert as follows: Fatal errors -> toggledlog.Fatal Warnings -> toggledlog.Warn Password prompts -> fmt.Fprintf

main: print actual error from LoadConfFile()

2016-06-05T11:44:22+00:00

It may not have been a "Wrong password" after all. Also, push down disabling the warning so LoadConfFile() can warn about things that matter.

configfile: use map[flagIota] for feature flags

2016-06-05T10:54:45+00:00

This should make things saner and more extensible. It prepares the infrastructure for "required feature flags" that will be used to deprecate old gocryptfs version.

configfile: bake the "Creator" gocryptfs version into the file

2016-06-05T09:40:13+00:00

This field is added for the convenience of users and may help them to identify which gocryptfs version they need to mount a filesystem. The same information is essentially contained in FeatureFlags, but this is more difficult to decode for humans. It is completely ignored programmatically (also by older gocryptfs versions).

fusefrontend: report an error if all files in a directory were invalid

2016-06-04T14:39:27+00:00

Just presenting an empty directory means that the user does not know that things went wrong unless he checks the syslog or tries to delete the directory. It would be nice to report the error even if only some files were invalid. However, go-fuse does not allow returning the valid directory entries AND an error.

nametransform, main: better error messages

2016-06-01T18:07:43+00:00

fusefrontend: replace unreliable "fd < 0" check

2016-05-30T07:36:06+00:00

... with the "released" boolean. For some reason, the "f.fd.Fd() < 0" check did not work reliably, leading to nil pointer panics on the following wlock.lock(). The problem was discovered during fsstress testing and is unlikely to happen in normal operations. With this change, we passed 1700+ fsstress iterations.