Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.1 2021-08-18T13:48:01+00:00 2021-08-18T13:48:01+00:00 Jakob Unterwurzacher 2021-08-18T13:47:17+00:00 urn:sha1:64793fedf4ac8eebe05c57af75877944c60f03a4 gocryptfs$ ineffassign ./... /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:243:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/configfile/config_file.go:272:2: ineffectual assignment to scryptHash /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/file.go:285:3: ineffectual assignment to fileID /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node.go:367:3: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/node_open_create.go:68:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/mount.go:308:2: ineffectual assignment to masterkey /home/jakob/go/src/github.com/rfjakob/gocryptfs/gocryptfs-xray/xray_main.go:156:13: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/fusefrontend/prepare_syscall_test.go:65:16: ineffectual assignment to errno /home/jakob/go/src/github.com/rfjakob/gocryptfs/internal/syscallcompat/open_nofollow_test.go:34:2: ineffectual assignment to fd /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:111:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:181:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/acl_test.go:198:2: ineffectual assignment to sz /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:365:8: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:30:6: ineffectual assignment to err /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/xattr/xattr_fd_test.go:66:6: ineffectual assignment to err 2021-08-11T18:28:20+00:00 Jakob Unterwurzacher 2021-08-11T18:28:20+00:00 urn:sha1:831e2256169abf85890e0ab54144b9041995e54d 2021-08-11T18:23:35+00:00 Jakob Unterwurzacher 2021-08-11T18:21:32+00:00 urn:sha1:2d386fc92e88be5384d1654db5d6e23ef4682354 We need to look at f_fstypename acc. to https://stackoverflow.com/a/52299141/1380267 : > As filesystem type numbers are now assigned at runtime in > recent versions of MacOS, you must use f_fstypename to > determine the type. https://github.com/rfjakob/gocryptfs/issues/585 2021-06-05T13:06:30+00:00 Jakob Unterwurzacher 2021-06-05T13:06:30+00:00 urn:sha1:e48f2377ec46f247d4db04cf8031702d0684c086 These are now available cross-platform in the unix package. 2021-06-02T17:10:36+00:00 Jakob Unterwurzacher 2021-06-02T17:10:36+00:00 urn:sha1:a38e5988bae3319a2c1c6745064f5785a0971d05 The result of setting an acl depends on who runs the operation! Fixes fuse-xfstests generic/375 (see https://github.com/rfjakob/fuse-xfstests/wiki/results_2021-05-19) 2021-05-26T11:17:56+00:00 Jakob Unterwurzacher 2021-05-23T10:00:09+00:00 urn:sha1:1b3c3b1347ef711ec38bb4c5cb14661035faf2ce GetdentsSpecial calls then Getdents syscall, with normal entries and "." / ".." split into two slices. 2021-05-22T20:01:46+00:00 Jakob Unterwurzacher 2021-05-22T20:01:46+00:00 urn:sha1:09870bfac51995a0a8875137ed9e6d60688240f1 Breakage was: +GOOS=darwin +GOARCH=amd64 +go build -tags without_openssl internal/fusefrontend/node_dir_ops.go:45:34: cannot use context (type *fuse.Context) as type *fuse.Caller in argument to syscallcompat.MkdiratUser internal/fusefrontend/node_dir_ops.go:83:35: cannot use context (type *fuse.Context) as type *fuse.Caller in argument to syscallcompat.MkdiratUser 2021-05-22T19:44:19+00:00 Jakob Unterwurzacher 2021-05-22T19:44:19+00:00 urn:sha1:e1853e10116e97d7dcce895d6603dae1379a37b7 Let's have MkdiratUser take fuse.Context like everybody else. 2021-05-22T19:39:29+00:00 Jakob Unterwurzacher 2021-05-22T19:37:41+00:00 urn:sha1:cb4f9f9e2934400fa0abf9bd6c65455783b2768e Turns out the whole euid switching logic can be shared when wrapping the syscall in a closure. 2021-03-14T13:43:11+00:00 Jakob Unterwurzacher 2021-03-14T13:43:11+00:00 urn:sha1:f6036c429a35dff83bd01b3e867262cf7e8468ef Give a user receiving the Getdents warning some background info.