Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7-rc2 2019-01-20T12:10:59+00:00 2019-01-20T12:10:59+00:00 Jakob Unterwurzacher 2019-01-20T12:10:59+00:00 urn:sha1:3d6b2685fb926b40b4eb528a8cbdc3871444d492 Breaks mounting on MacOS: unix.Faccessat on Darwin does NOT (yet) support AT_SYMLINK_NOFOLLOW. See d44fe89ba4f3252c5bd00c4f7730197732f2a26a . This reverts commit 0805a63df1b5f915b228727f6074c2506922d0ad. 2019-01-20T11:59:59+00:00 Jakob Unterwurzacher 2019-01-20T11:59:59+00:00 urn:sha1:0805a63df1b5f915b228727f6074c2506922d0ad unix.Faccessat has added support for AT_SYMLINK_NOFOLLOW in July 2018, https://github.com/golang/sys/commit/bd9dbc187b6e1dacfdd2722a87e83093c2d7bd6e#diff-341484dbbe3180cd7a31ef2ad2d679b6 which means we no longer need our own helper. Closes https://github.com/rfjakob/gocryptfs/issues/347 2019-01-16T19:55:20+00:00 Sebastian Lackner 2019-01-16T14:38:32+00:00 urn:sha1:682e642cfa556c2d72c4050bfb8e38febdec49b3 For Linux, everything effectively stays the same. For both path-based and fd-based Utimens() calls, we use unix.UtimesNanoAt(). To avoid introducing a separate syscall wrapper for futimens() (as done in go-fuse, for example), we instead use the /proc/self/fd - trick. On macOS, this changes quite a lot: * Path-based Utimens() calls were previously completely broken, since unix.UtimensNanoAt() ignores the passed file descriptor. Note that this cannot be fixed easily since there IS no appropriate syscall available on macOS prior to High Sierra (10.13). We emulate this case by using Fchdir() + setattrlist(). * Fd-based Utimens() calls were previously translated to f.GetAttr() (to fill any empty parameters) and syscall.Futimes(), which does not does support nanosecond precision. Both issues can be fixed by switching to fsetattrlist(). Fixes https://github.com/rfjakob/gocryptfs/issues/350 2019-01-14T21:11:15+00:00 Jakob Unterwurzacher 2019-01-14T21:11:15+00:00 urn:sha1:20140e24ed339ef97b4f3946da3b05f930898713 This should get rid of Openat: O_NOFOLLOW missing: flags = 0x0 Fchmodat: adding missing AT_SYMLINK_NOFOLLOW flag sys_common_test.go:203: chmod on symlink should have failed, but did not. New mode=0333 UnmountErr: "[...]/057376762.mnt" was not found in MountInfo, cannot check for FD leak and add some context to --- FAIL: TestUtimesNano (0.00s) matrix_test.go:628: no such file or directory See https://github.com/rfjakob/gocryptfs/pull/343#issuecomment-453888006 for full test output 2019-01-14T20:57:24+00:00 Jakob Unterwurzacher 2019-01-14T20:57:24+00:00 urn:sha1:6542ddd2f9416e73f4ba18d9451601ea35af7ff3 FchmodatNofollow dropped the flags parameter. 2019-01-14T20:54:16+00:00 Jakob Unterwurzacher 2019-01-14T20:54:16+00:00 urn:sha1:a7d59032d3790e117a48be6be1fb3a968266093b We never want Fchmodat to follow symlinks, so follow what Qemu does, and call our function FchmodatNofollow. 2019-01-14T20:27:28+00:00 Sebastian Lackner 2019-01-14T02:00:49+00:00 urn:sha1:a9d8eb49ef91c31fddc3e4f2f76e9b98e1a52a1d 2019-01-14T20:27:28+00:00 Sebastian Lackner 2019-01-14T01:56:06+00:00 urn:sha1:4134ff7570906d38d519b1aad33cd3e97685e92f 2019-01-14T20:27:28+00:00 Sebastian Lackner 2019-01-14T01:51:50+00:00 urn:sha1:7b0d56fe98a4ae449d26af0b83d00271a179db6e 2019-01-14T20:27:28+00:00 Sebastian Lackner 2019-01-14T01:49:11+00:00 urn:sha1:92110628ee5f48b0106b32090854fcc61d6bca20