gocryptfs/internal/syscallcompat, branch v1.4.2 Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.4.2 2017-10-22T16:13:08+00:00 tests: don't read /proc, the number of entries changes too quickly 2017-10-22T16:13:08+00:00 Jakob Unterwurzacher 2017-10-22T16:13:08+00:00 urn:sha1:34547a6c390bfadf2342df1676f6e5ddfa4876af This could lead to test failures like this: --- FAIL: TestGetdents (0.02s) getdents_test.go:57: len(getdentsEntries)=362, len(readdirEntries)=360 FAIL syscallcompat: Getdents: warn once if we get DT_UNKNOWN 2017-09-03T13:05:54+00:00 Jakob Unterwurzacher 2017-09-03T13:05:54+00:00 urn:sha1:538cae610cc4f7512cfb7a3b64a47e2fba9ea3c7 ...and if Getdents is not available at all. Due to this warning I now know that SSHFS always returns DT_UNKNOWN: gocryptfs[8129]: Getdents: convertDType: received DT_UNKNOWN, falling back to Lstat This behavoir is confirmed at http://ahefner.livejournal.com/16875.html: "With sshfs, I finally found that obscure case. The dtype is always set to DT_UNKNOWN [...]" syscallcompat: implement Getdents() 2017-08-15T17:03:57+00:00 Jakob Unterwurzacher 2017-08-13T19:13:44+00:00 urn:sha1:e50a6a57e57bc3cc925ba9a6e7f4dc1da4da3c84 The Readdir function provided by os is inherently slow because it calls Lstat on all files. Getdents gives us all the information we need, but does not have a proper wrapper in the stdlib. Implement the "Getdents()" wrapper function that calls syscall.Getdents() and parses the returned byte blob to a fuse.DirEntry slice. main, syscallcompat: use Dup3 instead of Dup2 2017-06-18T13:43:22+00:00 Jakob Unterwurzacher 2017-06-18T13:40:38+00:00 urn:sha1:a4563e21ecaf7d2acce64212c96de69707d6f0bb Dup2 is not implemented on linux/arm64. Fixes https://github.com/rfjakob/gocryptfs/issues/121 . Also adds cross-compilation to CI. syscallcompat: OSX compat: fix variable warnings 2017-02-16T18:23:17+00:00 Jakob Unterwurzacher 2017-02-16T18:23:17+00:00 urn:sha1:8bbc1038fe47a122e4d3854a37e6afe1afdc17bb As suggested by https://github.com/rfjakob/gocryptfs/issues/15#issuecomment-279130217 A few more lint fixes 2016-10-04T21:30:05+00:00 Jakob Unterwurzacher 2016-10-04T21:30:05+00:00 urn:sha1:a4956fa6bfde27c21f70e8577ebb586ccc9a3691 lint fixes 2016-10-04T21:18:33+00:00 Valient Gough 2016-10-02T04:14:18+00:00 urn:sha1:b764917cd5c1b1d61b8ce08e7af0b29793fbbb80 Add godoc comments to all internal packages 2016-07-06T19:51:25+00:00 Jakob Unterwurzacher 2016-07-06T19:51:25+00:00 urn:sha1:e8a234f658553927a2e845d64862321c90388e00 syscallcompat: OSX: add Mknodat wrapper 2016-07-03T18:22:22+00:00 Jakob Unterwurzacher 2016-07-03T18:21:29+00:00 urn:sha1:741bf0726e71c931af1dc1278571c280fc27970f Protip: find naked *at syscalls using: git grep "syscall." | grep "at(" | grep -v syscallcompat syscallcompat: OSX: add Unlinkat wrapper 2016-07-03T18:17:40+00:00 Jakob Unterwurzacher 2016-07-03T18:17:40+00:00 urn:sha1:d8524c73696392c7e895e6b3fe4c7e120d7296f7 Also, replace remaining naked syscall.Openat calls.