gocryptfs/internal/syscallcompat/getdents_test.go, branch xattr_user_bufferMirror of gocryptfs source code on Githubhttp://nuetzlich.net/cgit/gocryptfs/atom?h=xattr_user_buffer2025-07-07T17:59:35+00:00Fix a bunch of staticcheck errors2025-07-07T17:59:35+00:00Jakob Unterwurzacher2025-07-07T17:54:48+00:00urn:sha1:8f5df19b353e02ffba842fd1b15ccf93da7ee3b4
Tool-assisted.
make format2022-08-28T09:11:36+00:00Jakob Unterwurzacher2022-08-28T09:11:36+00:00urn:sha1:003a7fa2e53ac15d2c94a34102ae12b69b23c586Unbreak hyperlinks broken by go mod v2 conversion2021-08-30T09:31:01+00:00Jakob Unterwurzacher2021-08-30T09:31:01+00:00urn:sha1:34d8a498c4899b1493f7bea16c22486d6725c9b1
Commit
69d88505fd7f4cb0d9e4f1918de296342fe05858 go mod: declare module version v2
translated all instances of "github.com/rfjakob/gocryptfs/" to
"github.com/rfjakob/gocryptfs/v2/".
Unfortunately, this included hyperlinks.
Unbreak the hyperlinks like this:
find . -name \*.go | xargs sed -i s%https://github.com/rfjakob/gocryptfs/v2/%https://github.com/rfjakob/gocryptfs/v2/%
go mod: declare module version v22021-08-23T13:05:15+00:00Jakob Unterwurzacher2021-08-23T13:05:15+00:00urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858
Our git version is v2+ for some time now, but go.mod
still declared v1. Hopefully making both match makes
https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work.
All the import paths have been fixed like this:
find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/%
syscallcompat: add GetdentsSpecial()2021-05-26T11:17:56+00:00Jakob Unterwurzacher2021-05-23T10:00:09+00:00urn:sha1:1b3c3b1347ef711ec38bb4c5cb14661035faf2ce
GetdentsSpecial calls then Getdents syscall,
with normal entries and "." / ".." split into two slices.
Update go-fuse import path to github.com/hanwen/go-fuse/v22020-05-17T12:23:47+00:00Jakob Unterwurzacher2020-05-17T12:18:23+00:00urn:sha1:ec74d1d2f4217a9a337d1db9902f32ae2aecaf33
We need
https://github.com/hanwen/go-fuse/commit/fd7328faf9fdf75709f7ba7df7072aaf4eeb18b3
to fix a crash reported in https://github.com/rfjakob/gocryptfs/issues/430 :
2019/10/30 17:14:16 Unknown opcode 2016
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x508d38]
This patch is only in the v2.x.x branch. Upgrade to v2, as the
old API is also supported there.
Running
git grep hanwen/go-fuse | grep -v hanwen/go-fuse/v2
to check for forgotten references comes back clean.
gccgo: skip emulateGetdents on linux2018-02-04T20:14:12+00:00Jakob Unterwurzacher2018-02-04T20:13:14+00:00urn:sha1:8151222ada4c687bfad7e2f35c73aacbbc24c6b5
The test is known to fail on gccgo
(https://github.com/rfjakob/gocryptfs/issues/201), but
getdents emulation is not used on linux, so let's skip
the test and ignore the failure.
gccgo: replace syscall.NAME_MAX with unix.NAME_MAX2018-02-01T22:50:11+00:00Jakob Unterwurzacher2018-02-01T22:46:02+00:00urn:sha1:9f8d0d8e5734e3771b52c8a8784ef5a76b0f9ca8
For some reason the syscall.NAME_MAX constant does not exist
on gccgo, and it does not hurt us to use unix.NAME_MAX instead.
https://github.com/rfjakob/gocryptfs/issues/201
syscallcompat: convert Getdents to fd input, add emulation2017-12-03T18:33:26+00:00Jakob Unterwurzacher2017-12-03T16:57:08+00:00urn:sha1:70bcf58a9bda5f95a3037fb785858f5d7ce3f930
Now that we have Fstatat we can use it in Getdents to
get rid of the path name.
Also, add an emulated version of getdents for MacOS. This allows
to drop the !HaveGetdents special cases from fusefrontend.
Modify the getdents test to test both native getdents and the emulated
version.
tests: don't read /proc, the number of entries changes too quickly2017-10-22T16:13:08+00:00Jakob Unterwurzacher2017-10-22T16:13:08+00:00urn:sha1:34547a6c390bfadf2342df1676f6e5ddfa4876af
This could lead to test failures like this:
--- FAIL: TestGetdents (0.02s)
getdents_test.go:57: len(getdentsEntries)=362, len(readdirEntries)=360
FAIL