gocryptfs/internal/readpassword, branch v1.2.1Mirror of gocryptfs source code on Githubhttp://nuetzlich.net/cgit/gocryptfs/atom?h=v1.2.12017-02-13T08:13:22+00:00readpassword: limit password length to 1000 bytes2017-02-13T08:13:22+00:00Jakob Unterwurzacher2017-02-13T08:13:22+00:00urn:sha1:3784901fcee46d3e14e154b32cc6a7822bcc90f6
This used to hang at 100% CPU:
cat /dev/zero | gocryptfs -init a
...and would ultimately send the box into out-of-memory.
The number 1000 is chosen arbitrarily and seems big enough
given that the password must be one line.
Suggested by @mhogomchungu in https://github.com/rfjakob/gocryptfs/issues/77 .
Check for trailing garbage after the password2017-02-12T16:59:09+00:00Jakob Unterwurzacher2017-02-12T14:35:50+00:00urn:sha1:8adfbf2dc34560df7436c89b59a9749d2dd3b78e
From the comment:
// CheckTrailingGarbage tries to read one byte from stdin and exits with a
// fatal error if the read returns any data.
// This is meant to be called after reading the password, when there is no more
// data expected. This helps to catch problems with third-party tools that
// interface with gocryptfs.
readpassword: improve comment on readPasswordStdin2017-02-12T12:55:30+00:00Jakob Unterwurzacher2017-02-12T12:55:15+00:00urn:sha1:2dd90ac19ce97544c412d90a24df0f68e66311dbreadpassword: support spaces in "-passfile" filename2017-01-28T23:34:12+00:00Jakob Unterwurzacher2017-01-28T23:34:12+00:00urn:sha1:6166dad05c1bf505f1c0fca1fbe8bf6a27d02db9
...and while we are at it, also filenames starting with "-".
readpassword: check extpass return code2016-10-16T14:44:27+00:00Jakob Unterwurzacher2016-10-16T14:44:27+00:00urn:sha1:b2d33028a6121f2b2a53d3ffe96dd235d59249f1
...and exit if it is not zero.
lint fixes2016-10-04T21:18:33+00:00Valient Gough2016-10-02T04:14:18+00:00urn:sha1:b764917cd5c1b1d61b8ce08e7af0b29793fbbb80Add godoc comments to all internal packages2016-07-06T19:51:25+00:00Jakob Unterwurzacher2016-07-06T19:51:25+00:00urn:sha1:e8a234f658553927a2e845d64862321c90388e00tests: exit with correct error code from TestMain2016-06-16T19:56:23+00:00Jakob Unterwurzacher2016-06-16T19:56:23+00:00urn:sha1:96750a7d3c52b75d13d6f3ed46bd48af28acebcd
extpass_test and example_filesystems_test did it wrong,
always returning 0.
readpassword: clean up leftover debug commit2016-06-16T18:59:51+00:00Jakob Unterwurzacher2016-06-16T18:59:51+00:00urn:sha1:c76c952c192f5378eb713f4f3435de29af0f7922Rename internal "toggledlog" package to "tlog"2016-06-15T21:30:44+00:00Jakob Unterwurzacher2016-06-15T21:30:44+00:00urn:sha1:6c3f97399a01a2d8480b39978209099335efbf7d
tlog is used heavily everywhere and deserves a shorter name.
Renamed using sed magic, without any manual rework:
find * -type f -exec sed -i 's/toggledlog/tlog/g' {} +