gocryptfs/internal/readpassword, branch detMirror of gocryptfs source code on Githubhttp://nuetzlich.net/cgit/gocryptfs/atom?h=det2017-05-14T12:02:08+00:00exitcodes: add code 22 for "password is empty"2017-05-14T12:02:08+00:00Jakob Unterwurzacher2017-05-14T12:02:08+00:00urn:sha1:2aea2d3d62e5df4c8bf25195dc97e60b495f6f12
Empty passwords are not allowed. Let's give the error
it's own exit code.
exitcodes: pull all exit code definitions into the package2017-05-07T20:16:22+00:00Jakob Unterwurzacher2017-05-07T20:15:01+00:00urn:sha1:d5adde1eeb13ba377f7c05b9f21893c01f61ec16
This commit defines all exit codes in one place in the exitcodes
package.
Also, it adds a test to verify the exit code on incorrect
password, which is what SiriKali cares about the most.
Fixes https://github.com/rfjakob/gocryptfs/issues/77 .
readpassword: increase max password size to 20482017-04-29T13:15:11+00:00Jakob Unterwurzacher2017-04-29T13:15:11+00:00urn:sha1:6e029a3799816dd6703b2cb573022c7c3fd15c39
This is the value EncFS uses, so let's follow suit.
Suggested at https://github.com/rfjakob/gocryptfs/issues/77 .
readpassword: increase max password length to 20002017-03-20T08:29:56+00:00Jakob Unterwurzacher2017-03-20T08:29:56+00:00urn:sha1:2824218a25bef58167d922dddbb10ad0e022db6d
1000 was too low as at least one user had a password
that was longer.
Fixes https://github.com/rfjakob/gocryptfs/issues/93
readpassword: limit password length to 1000 bytes2017-02-13T08:13:22+00:00Jakob Unterwurzacher2017-02-13T08:13:22+00:00urn:sha1:3784901fcee46d3e14e154b32cc6a7822bcc90f6
This used to hang at 100% CPU:
cat /dev/zero | gocryptfs -init a
...and would ultimately send the box into out-of-memory.
The number 1000 is chosen arbitrarily and seems big enough
given that the password must be one line.
Suggested by @mhogomchungu in https://github.com/rfjakob/gocryptfs/issues/77 .
Check for trailing garbage after the password2017-02-12T16:59:09+00:00Jakob Unterwurzacher2017-02-12T14:35:50+00:00urn:sha1:8adfbf2dc34560df7436c89b59a9749d2dd3b78e
From the comment:
// CheckTrailingGarbage tries to read one byte from stdin and exits with a
// fatal error if the read returns any data.
// This is meant to be called after reading the password, when there is no more
// data expected. This helps to catch problems with third-party tools that
// interface with gocryptfs.
readpassword: improve comment on readPasswordStdin2017-02-12T12:55:30+00:00Jakob Unterwurzacher2017-02-12T12:55:15+00:00urn:sha1:2dd90ac19ce97544c412d90a24df0f68e66311dbreadpassword: support spaces in "-passfile" filename2017-01-28T23:34:12+00:00Jakob Unterwurzacher2017-01-28T23:34:12+00:00urn:sha1:6166dad05c1bf505f1c0fca1fbe8bf6a27d02db9
...and while we are at it, also filenames starting with "-".
readpassword: check extpass return code2016-10-16T14:44:27+00:00Jakob Unterwurzacher2016-10-16T14:44:27+00:00urn:sha1:b2d33028a6121f2b2a53d3ffe96dd235d59249f1
...and exit if it is not zero.
lint fixes2016-10-04T21:18:33+00:00Valient Gough2016-10-02T04:14:18+00:00urn:sha1:b764917cd5c1b1d61b8ce08e7af0b29793fbbb80