gocryptfs/internal/nametransform, branch v1.7-rc1 Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7-rc1 2019-01-04T00:23:44+00:00 A few more spelling fixes. 2019-01-04T00:23:44+00:00 Sebastian Lackner 2019-01-03T20:08:49+00:00 urn:sha1:ab169443fde9c6697b5b9dc010691cbc61cd5206 Found with the 'codespell' utility. nametransform: Add implicit syscall.O_RDONLY flag. 2019-01-03T17:24:05+00:00 Sebastian Lackner 2019-01-03T16:51:23+00:00 urn:sha1:61241b05889bda6e70446eab571f138d5d6f6c20 fusefrontend: add dirCache 2019-01-03T14:31:13+00:00 Jakob Unterwurzacher 2019-01-02T21:32:21+00:00 urn:sha1:4f66d66755da63c78b09201c6c72353009251cf2 nametransform: simplify WriteDirIV to WriteDirIVAt 2019-01-03T14:31:13+00:00 Jakob Unterwurzacher 2019-01-03T12:32:13+00:00 urn:sha1:f6dad8d0fae25b5d88ad036b841fea10b7296ccb Un-spaghettify the function and let the callers open the directory. fusefronted: make EncryptPath symlink-safe 2019-01-02T20:45:40+00:00 Jakob Unterwurzacher 2019-01-02T20:45:40+00:00 urn:sha1:2b12bba274ba75f76ac8c2af3790e4190b32396f Finally allows us to delete EncryptPathDirIV. nametransform: fix possible incomplete read in ReadLongNameAt 2019-01-01T23:09:17+00:00 Jakob Unterwurzacher 2019-01-01T23:07:20+00:00 urn:sha1:d99a0480f712d4fd1c2012c57a9e1c938d70c9fe Pread() needs retry logic, so instead of implementing it ourselves, use os.File. Reported by @slackner at https://github.com/rfjakob/gocryptfs/commit/c09bf1f2284706232642431c75fa1f3d8500a9d0#r31813394 nametransform: rename WriteLongName() -> WriteLongNameAt() 2019-01-01T15:24:25+00:00 Jakob Unterwurzacher 2018-11-04T21:05:38+00:00 urn:sha1:2de3851abddd26949b72b9b255ce836fc93ed284 And also rename DeleteLongName() -> DeleteLongNameAt(). The naming follow the names open the openat() etc syscalls. fusefrontend: make OpenDir() symlink-safe 2019-01-01T15:24:25+00:00 Jakob Unterwurzacher 2018-11-04T20:46:51+00:00 urn:sha1:21f1f858b9bebb20fdb9bb3f99189279bb6c6976 Interestingly, little or no performance impact: $ ./benchmark.bash Testing gocryptfs at /tmp/benchmark.bash.39W: gocryptfs v1.6-42-g30c2349-dirty; go-fuse v20170619-66-g6df8ddc; 2018-11-04 go1.11 Downloading linux-3.0.tar.gz /tmp/linux-3.0.tar.gz 100%[=========================================================================>] 92.20M 2.93MB/s in 31s 2018-11-04 21:44:44 URL:https://cdn.kernel.org/pub/linux/kernel/v3.0/linux-3.0.tar.gz [96675825/96675825] -> "/tmp/linux-3.0.tar.gz" [1] WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.1808 s, 222 MB/s READ: 262144000 bytes (262 MB, 250 MiB) copied, 0.866438 s, 303 MB/s UNTAR: 24.745 MD5: 12.050 LS: 3.525 RM: 9.544 Note: kernel has been updated: $ uname -a Linux brikett 4.18.16-200.fc28.x86_64 #1 SMP Sat Oct 20 23:53:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux fusefrontend: mark a few more functions as symlink-safe / unsafe 2019-01-01T15:24:25+00:00 Jakob Unterwurzacher 2018-11-04T20:29:17+00:00 urn:sha1:de3a2c189578f7636c39fde44fbe1da9c78b367e fusefrontend: make openBackingDir() symlink-safe 2019-01-01T15:24:09+00:00 Jakob Unterwurzacher 2018-10-14T18:11:49+00:00 urn:sha1:932efbd4593fe6be6c86f0dafeaea32910b7c246 openBackingDir() used encryptPath(), which is not symlink-safe itself. Drop encryptPath() and implement our own directory walk. Adds three seconds to untar and two seconds to rm: $ ./benchmark.bash Testing gocryptfs at /tmp/benchmark.bash.MzG: gocryptfs v1.6-36-g8fb3c2f-dirty; go-fuse v20170619-66-g6df8ddc; 2018-10-14 go1.11 WRITE: 262144000 bytes (262 MB, 250 MiB) copied, 1.25078 s, 210 MB/s READ: 262144000 bytes (262 MB, 250 MiB) copied, 1.0318 s, 254 MB/s UNTAR: 20.941 MD5: 11.568 LS: 1.638 RM: 5.337