gocryptfs/internal/fusefrontend_reverse, branch v1.7-rc2Mirror of gocryptfs source code on Githubhttp://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7-rc22019-01-20T12:10:59+00:00Revert "syscallcompat: drop Faccessat AT_SYMLINK_NOFOLLOW helper"2019-01-20T12:10:59+00:00Jakob Unterwurzacher2019-01-20T12:10:59+00:00urn:sha1:3d6b2685fb926b40b4eb528a8cbdc3871444d492
Breaks mounting on MacOS: unix.Faccessat on Darwin does NOT (yet)
support AT_SYMLINK_NOFOLLOW. See d44fe89ba4f3252c5bd00c4f7730197732f2a26a .
This reverts commit 0805a63df1b5f915b228727f6074c2506922d0ad.
syscallcompat: drop Faccessat AT_SYMLINK_NOFOLLOW helper2019-01-20T11:59:59+00:00Jakob Unterwurzacher2019-01-20T11:59:59+00:00urn:sha1:0805a63df1b5f915b228727f6074c2506922d0ad
unix.Faccessat has added support for AT_SYMLINK_NOFOLLOW in July 2018,
https://github.com/golang/sys/commit/bd9dbc187b6e1dacfdd2722a87e83093c2d7bd6e#diff-341484dbbe3180cd7a31ef2ad2d679b6
which means we no longer need our own helper.
Closes https://github.com/rfjakob/gocryptfs/issues/347
fusefrontend_reverse: Delete leftover debug statement.2019-01-15T21:07:37+00:00Sebastian Lackner2019-01-15T10:31:35+00:00urn:sha1:d8bb223dd3f3449b4a2d4962292bfa18e2f8b3b6fusefrontend_reverse: Fix redeclaration of 'entries' variable.2019-01-04T19:11:45+00:00Sebastian Lackner2019-01-04T18:52:17+00:00urn:sha1:117dc3f2cc83831a955838ac8ceaeb962b9c8827
Go version go1.10.7 linux/amd64 complains with:
internal/fusefrontend_reverse/rfs.go:333: declaration of "entries" shadows
declaration at internal/fusefrontend_reverse/rfs.go:327
reverse mode: -exclude: filter out excluded .name files2019-01-04T16:59:00+00:00Jakob Unterwurzacher2019-01-04T16:59:00+00:00urn:sha1:6b94f5ef51c92f471919e7542a0ce45b0859282f
Fixes https://github.com/rfjakob/gocryptfs/issues/286 :
While the actual file is properly excluded, the * .name file is still leaked in the directory listing:
```
drwxr-xr-x 2 sebastian sebastian 4,0K Dez 17 14:58 .
drwxr-xr-x 7 sebastian sebastian 4,0K Dez 17 14:45 ..
-r-------- 1 sebastian sebastian 408 Dez 17 14:56 gocryptfs.conf
-r--r--r-- 1 sebastian sebastian 16 Dez 17 14:58 gocryptfs.diriv
-r--r--r-- 1 sebastian sebastian 320 Dez 17 14:58 gocryptfs.longname.3vZ_r3eDPb1_fL3j5VA4rd_bcKWLKT9eaxOVIGK5HFA.name
```
reverse mode: fix "-exclude" in "-plaintextnames" dir listings2019-01-04T16:36:06+00:00Jakob Unterwurzacher2019-01-04T16:34:21+00:00urn:sha1:75a3e2c2eed3c19444b8aa131337757b7a05c7b7
Excluded files showed up in directory listing like this:
drwxr-xr-x 2 sebastian sebastian 4,0K Dez 17 14:48 .
drwxr-xr-x 7 sebastian sebastian 4,0K Dez 17 14:45 ..
-????????? ? ? ? ? ? abcd
-r-------- 1 sebastian sebastian 366 Dez 17 14:45 gocryptfs.conf
Fixes https://github.com/rfjakob/gocryptfs/issues/285
syscallcompat: use O_PATH in OpenDirNofollow2018-09-08T16:06:33+00:00Jakob Unterwurzacher2018-09-08T16:06:33+00:00urn:sha1:930c37e03d5ff80e7cdc9f0ca2cd35d80a06d5c0
This fixes the "0100 directory" problem in reverse mode,
and should be slightly faster.
syscallcompat: untangle OpenNofollow and rename to OpenDirNofollow2018-09-08T15:41:17+00:00Jakob Unterwurzacher2018-09-08T15:41:17+00:00urn:sha1:9ec9d0c49cfbdc9ceba10d7534b77e527c0a3cdc
The function used to do two things:
1) Walk the directory tree in a manner safe from symlink attacks
2) Open the final component in the mode requested by the caller
This change drops (2), which was only used once, and lets the caller
handle it. This simplifies the function and makes it fit for reuse in
forward mode in openBackingPath(), and for using O_PATH on Linux.
fusefrontend_reverse: reject excludes for the root directory ""2018-08-15T10:28:29+00:00Jakob Unterwurzacher2018-08-15T10:28:29+00:00urn:sha1:7a02f71fc2fc8fc104ad1538f417d1e93e73cf11
This is most likely a mistake by the user. Reject it.
reverse mode: add --exclude option2018-08-11T21:26:49+00:00Jakob Unterwurzacher2018-08-11T21:26:49+00:00urn:sha1:ec2fdc19cf9358ae7ba09c528a5807b6b0760f9b
https://github.com/rfjakob/gocryptfs/issues/235