Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.8.0 2020-04-19T20:00:56+00:00 2020-04-19T20:00:56+00:00 Jakob Unterwurzacher 2020-04-19T19:57:53+00:00 urn:sha1:9f9d59ded94f648202505e278f67667879e60be8 Adding flags allows to use inomap in reverse mode, replacing the clunky inoBaseDirIV/inoBaseNameFile logic that causes problems with high underlying inode numbers ( https://github.com/rfjakob/gocryptfs/issues/457 ) Microbenchmarks (values below) show that the "SingleDev" case is now much slower due to an extra map lookup, but this has no visible effects in ./test.bash results, so there was no time spent optimizing the case further. $ go test -bench=. goos: linux goarch: amd64 pkg: github.com/rfjakob/gocryptfs/internal/inomap BenchmarkTranslateSingleDev-4 18757510 61.5 ns/op BenchmarkTranslateManyDevs-4 18061515 64.5 ns/op PASS ok github.com/rfjakob/gocryptfs/internal/inomap 2.467s 2020-04-13T12:54:04+00:00 Jakob Unterwurzacher 2020-04-12T15:15:03+00:00 urn:sha1:488111ce390218806fca933b89279b766f7ff49c inomap will also be used by fusefrontend_reverse in the future. Split if off openfiletable to make it independent. 2020-02-29T19:12:43+00:00 Jakob Unterwurzacher 2020-02-29T18:58:08+00:00 urn:sha1:ca9e912a28b901387e1dbb85f6c531119f2d5ef2 We used to restrict setting xattrs to the "user." namespace. I don't see a real reason for this anymore, and it causes trouble for users who are using acls. Tests will be added in the next commit. https://github.com/rfjakob/gocryptfs/issues/453 2019-11-16T22:21:37+00:00 Jakob Unterwurzacher 2019-11-16T22:21:37+00:00 urn:sha1:8ec804d825370ccf06fd9a7c6fb5589e3c2c17c2 Error from Travis CI was: +GOOS=darwin +GOARCH=amd64 +go build -tags without_openssl # github.com/rfjakob/gocryptfs/internal/fusefrontend internal/fusefrontend/fs.go:88:45: cannot use st.Dev (type int32) as type uint64 in argument to openfiletable.NewInumMap Add uint64 to fix it. 2019-11-16T20:36:27+00:00 Jakob Unterwurzacher 2019-11-16T20:36:27+00:00 urn:sha1:bb6155a51ff7a521d948ec58723d211bfaf8a731 translate inode numbers on different devices to fix collisions. Fixes https://github.com/rfjakob/gocryptfs/issues/435 2019-11-03T19:38:15+00:00 Jakob Unterwurzacher 2019-11-03T19:38:15+00:00 urn:sha1:e4148028af1f113bfdec00f3c577ef2d428a6aad The comment is outdated, at this point, we should really not get any errors from ReadDirIVAt. The change is best seen when running the fsck tests. Before: fsck: error opening dir "missing_diriv": 2=no such file or directory After: OpenDir "K2m0E6qzIfoLkVZJanoUiQ": could not read gocryptfs.diriv: no such file or directory fsck: error opening dir "missing_diriv": 5=input/output error See https://github.com/rfjakob/gocryptfs/issues/403 , where the extra info would have been helpful. 2019-11-03T19:12:05+00:00 Jakob Unterwurzacher 2019-11-03T19:12:05+00:00 urn:sha1:93939961f57e881f2b82293aa8749ea6f1ba6180 This was meant as a way to inform the user that something is very wrong, however, users are hitting the condition on MacOS due to ".DS_Store" files, and also on NFS due to ".nfsXXX" files. Drop the whole thing as it seems to cause more pain than gain. Fixes https://github.com/rfjakob/gocryptfs/issues/431 2019-10-06T19:47:36+00:00 Jakob Unterwurzacher 2019-10-06T19:27:38+00:00 urn:sha1:00af4f48643f0533b6cfbd14fdf5186c844f8f5d Closing the fd means the inode number may be reused immediately by a new file, so we have to get the old fileID out of the table beforehand! Hopefully fixes https://github.com/rfjakob/gocryptfs/issues/363 2019-10-06T17:37:51+00:00 Jakob Unterwurzacher 2019-10-06T17:36:04+00:00 urn:sha1:43265940fa2d43ebea8edb00373aa4d6718e2ea7 This should help debugging https://github.com/rfjakob/gocryptfs/issues/363 , but does no harm in normal operation as it only prints ciphertext to the log. 2019-09-08T14:29:20+00:00 Jakob Unterwurzacher 2019-09-08T14:29:20+00:00 urn:sha1:0a4db7d9e9801a416602b52281537991ba1463c0 Fixes https://github.com/rfjakob/gocryptfs/issues/421