Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7 2019-02-17T16:05:05+00:00 2019-02-17T16:05:05+00:00 Jakob Unterwurzacher 2019-02-17T16:05:05+00:00 urn:sha1:19cb6d046aac92f44722c17ba9a371b08ca0be6a Looks like we allowed creating longer names by accident. Fix that, and add a test that verifies it. 2019-01-20T13:37:36+00:00 Jakob Unterwurzacher 2019-01-20T12:34:46+00:00 urn:sha1:b08cbce5c1244f901e58812402d82a1816ecf436 https://github.com/rfjakob/gocryptfs/issues/347 2019-01-20T13:29:28+00:00 Jakob Unterwurzacher 2019-01-20T13:29:28+00:00 urn:sha1:962c52364415496b64a42b49fe5f90d593dc09f7 This fixed the "Permission denied" bug, but still has the problem that the directory may be replaced behind our back. Mitigated by the fact that we skip the workaround when running as root with -allow_other. https://github.com/rfjakob/gocryptfs/issues/354 2019-01-20T12:10:59+00:00 Jakob Unterwurzacher 2019-01-20T12:10:59+00:00 urn:sha1:3d6b2685fb926b40b4eb528a8cbdc3871444d492 Breaks mounting on MacOS: unix.Faccessat on Darwin does NOT (yet) support AT_SYMLINK_NOFOLLOW. See d44fe89ba4f3252c5bd00c4f7730197732f2a26a . This reverts commit 0805a63df1b5f915b228727f6074c2506922d0ad. 2019-01-20T11:59:59+00:00 Jakob Unterwurzacher 2019-01-20T11:59:59+00:00 urn:sha1:0805a63df1b5f915b228727f6074c2506922d0ad unix.Faccessat has added support for AT_SYMLINK_NOFOLLOW in July 2018, https://github.com/golang/sys/commit/bd9dbc187b6e1dacfdd2722a87e83093c2d7bd6e#diff-341484dbbe3180cd7a31ef2ad2d679b6 which means we no longer need our own helper. Closes https://github.com/rfjakob/gocryptfs/issues/347 2019-01-16T19:55:20+00:00 Sebastian Lackner 2019-01-16T14:32:16+00:00 urn:sha1:452b8b00f426c9e745fcdeb3677147d492406f6f 2019-01-16T19:55:20+00:00 Sebastian Lackner 2019-01-16T14:38:32+00:00 urn:sha1:682e642cfa556c2d72c4050bfb8e38febdec49b3 For Linux, everything effectively stays the same. For both path-based and fd-based Utimens() calls, we use unix.UtimesNanoAt(). To avoid introducing a separate syscall wrapper for futimens() (as done in go-fuse, for example), we instead use the /proc/self/fd - trick. On macOS, this changes quite a lot: * Path-based Utimens() calls were previously completely broken, since unix.UtimensNanoAt() ignores the passed file descriptor. Note that this cannot be fixed easily since there IS no appropriate syscall available on macOS prior to High Sierra (10.13). We emulate this case by using Fchdir() + setattrlist(). * Fd-based Utimens() calls were previously translated to f.GetAttr() (to fill any empty parameters) and syscall.Futimes(), which does not does support nanosecond precision. Both issues can be fixed by switching to fsetattrlist(). Fixes https://github.com/rfjakob/gocryptfs/issues/350 2019-01-15T21:07:37+00:00 Sebastian Lackner 2019-01-15T10:35:20+00:00 urn:sha1:8f331456511a14d8d936bd4bdc60c4bf587b4d3a While we're at it, also replace os.* constants with syscall.* constants. 2019-01-14T20:54:16+00:00 Jakob Unterwurzacher 2019-01-14T20:54:16+00:00 urn:sha1:a7d59032d3790e117a48be6be1fb3a968266093b We never want Fchmodat to follow symlinks, so follow what Qemu does, and call our function FchmodatNofollow. 2019-01-13T19:27:35+00:00 Jakob Unterwurzacher 2019-01-13T19:27:35+00:00 urn:sha1:e885f087462338b4d65f0c12a004f57dc513b839 The only call forwarded to loopbackFileSystem was Statfs, which is trivial to implement. Implement it and drop loopbackFileSystem, as having it carries the risk that a coding error bypasses the usual encryption/decryption chain.