gocryptfs/internal/fusefrontend, branch v0.12

Rename internal "toggledlog" package to "tlog"

2016-06-15T21:30:44+00:00

tlog is used heavily everywhere and deserves a shorter name. Renamed using sed magic, without any manual rework: find * -type f -exec sed -i 's/toggledlog/tlog/g' {} +

Fix warnings reported by Go 1.6 "go tool vet -shadow=true"

2016-06-14T20:46:23+00:00

Warnings were: main.go:234: declaration of err shadows declaration at main.go:163: internal/fusefrontend/file.go:401: declaration of err shadows declaration at internal/fusefrontend/file.go:379: internal/fusefrontend/file.go:419: declaration of err shadows declaration at internal/fusefrontend/file.go:379: internal/fusefrontend/fs_dir.go:140: declaration of err shadows declaration at internal/fusefrontend/fs_dir.go:97:

fusefrontend: Utimens: convert ENOENT to EBADF

2016-06-09T20:21:00+00:00

If /proc/self/fd/X did not exist, the actual error is that the file descriptor was invalid. go-fuse's pathfs prefers using an open fd even for path-based operations but does not take any locks to prevent the fd from being closed. Instead, it retries the operation by path if it get EBADF. So this change allows the retry logic to work correctly. This fixes the error rsync: failed to set times on "/tmp/ping.Kgw.mnt/linux-3.0/[...]/.dvb_demux.c.N7YlEM": No such file or directory (2) that was triggered by pingpong-rsync.bash.

fusefrontend: fix chown on dangling symlinks

2016-06-07T22:32:44+00:00

We (actually, go-fuse) used to call Chown() instead of Lchown() which meant that the operation would fail on dangling symlinks. Fix this by calling os.Lchown() ourself. Also add a test case for this.

fusefrontend: report an error if all files in a directory were invalid

2016-06-04T14:39:27+00:00

Just presenting an empty directory means that the user does not know that things went wrong unless he checks the syslog or tries to delete the directory. It would be nice to report the error even if only some files were invalid. However, go-fuse does not allow returning the valid directory entries AND an error.

fusefrontend: replace unreliable "fd < 0" check

2016-05-30T07:36:06+00:00

... with the "released" boolean. For some reason, the "f.fd.Fd() < 0" check did not work reliably, leading to nil pointer panics on the following wlock.lock(). The problem was discovered during fsstress testing and is unlikely to happen in normal operations. With this change, we passed 1700+ fsstress iterations.

fusefrontend: use sync.Once for one-time warnings

2016-05-29T20:50:03+00:00

Using a simple boolean was racy (which was harmless in this case) and non-idomatic.

fusefronted: check Fstat return value on file create

2016-05-29T20:43:48+00:00

The Fstat call should never fail, but still, if it does return an error it should be handled properly.

fusefrontend: simplify wlockMap

2016-05-29T20:40:05+00:00

mapMutex can be anonymous and using an RWMutex is overkill because the lock protects very short sections.

fusefrontend: remove unused "forgotten" variable

2016-05-29T11:46:47+00:00

The functionality has long been replaced by the fd < 0 check.