gocryptfs/internal/ctlsock, branch det Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=det 2017-05-07T10:22:15+00:00 Fix typos found by Misspell 2017-05-07T10:22:15+00:00 Jakob Unterwurzacher 2017-05-07T10:22:15+00:00 urn:sha1:68387b470c0d6d2896cc6b927a6e3097389d66ab Misspell Finds commonly misspelled English words gocryptfs/internal/configfile/scrypt.go Line 41: warning: "paramter" is a misspelling of "parameter" (misspell) gocryptfs/internal/ctlsock/ctlsock_serve.go Line 1: warning: "implementes" is a misspelling of "implements" (misspell) gocryptfs/tests/test_helpers/helpers.go Line 27: warning: "compatability" is a misspelling of "compatibility" (misspell) ctlsock: handle non-canonical empty paths 2017-02-05T17:17:30+00:00 Jakob Unterwurzacher 2017-02-05T17:07:14+00:00 urn:sha1:0f40afc8321746ebd0ba0131b3296dd160f84ccc We have to check if the input path is empty AFTER canonicalizing it, too! ctlsock: sanitize: handle multiple leading slashes 2017-02-05T17:05:35+00:00 Jakob Unterwurzacher 2017-02-05T17:05:35+00:00 urn:sha1:8bcae63a5a375d918aad9f2c18804867730378e1 golint comment fix 2017-01-29T18:01:16+00:00 Jakob Unterwurzacher 2017-01-29T18:01:16+00:00 urn:sha1:2bdd0ec802611101969a7b59c3bb7a7a1be64e9d internal/ctlsock/ctlsock_serve.go:73:1: comment on exported const ReadBufSize should be of the form "ReadBufSize ..." ctlsock: abort message processing on JSON error 2017-01-29T17:25:46+00:00 Jakob Unterwurzacher 2017-01-29T17:24:47+00:00 urn:sha1:53fe6f569042200b9a390bccb589829ce1ec0dce The code was missing a "continue" in that branch. Also improve the error messages a bit. ctlsock: interpret paths that point above CWD as "" 2017-01-29T14:24:47+00:00 Jakob Unterwurzacher 2017-01-29T14:24:47+00:00 urn:sha1:532ef15417072cf6c6bd6576d78588f96800fa43 Paths that start with ".." were previously accepted as-is. ctlsock: abort the connection if the request is too big 2016-12-10T19:43:08+00:00 Jakob Unterwurzacher 2016-12-10T19:41:40+00:00 urn:sha1:12374be9c51b0298c85751e4652fe4e852c85546 Reading partial JSON would cause a mess. Just kill the connection. Also, stop using syscall.PathMax that is not defined on Darwin ( https://github.com/rfjakob/gocryptfs/issues/15#issuecomment-264253024 ) ctlsock: add a note about Accept() throwing errors on Close() 2016-12-10T14:01:00+00:00 Jakob Unterwurzacher 2016-12-10T14:01:00+00:00 urn:sha1:8945f4db95ec75dd1f9de763ae249d9e433d3732 ctlsock: exit early if socket cannot be created; delete on exit 2016-12-10T13:54:06+00:00 Jakob Unterwurzacher 2016-12-10T13:54:06+00:00 urn:sha1:6af725ff099e78fab2920f060c127415aa3b1893 Both are achieved by opening the socket from main and passing it to the ctlsock package instead of passing the path. ctlsock: sanitize paths before passing them to the backend 2016-12-10T11:59:54+00:00 Jakob Unterwurzacher 2016-12-10T11:59:54+00:00 urn:sha1:2758c75cae2896b7f1327fe00f60a1c017c0e0d1 You used to be able to crash gocryptfs by passing "/foo" of "foo/" to the ctlsock. Fixes https://github.com/rfjakob/gocryptfs/issues/66