Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=xattr_user_buffer 2021-09-28T16:35:37+00:00 2021-09-28T16:35:37+00:00 Jakob Unterwurzacher 2021-09-28T16:35:37+00:00 urn:sha1:75cace05684df3afa1f2519ec59f73fcdfac25f5 Reported by codacity: internal/cryptocore/cryptocore.go Minor icon MINOR Code Style should omit type AEADTypeEnum from declaration of var BackendAESSIV; it will be inferred from the right-hand side var BackendAESSIV AEADTypeEnum = AEADTypeEnum{"AES-SIV-512", "Go", siv_aead.NonceSize} Minor icon MINOR Code Style should omit type AEADTypeEnum from declaration of var BackendXChaCha20Poly1305; it will be inferred from the right-hand side var BackendXChaCha20Poly1305 AEADTypeEnum = AEADTypeEnum{"XChaCha20-Poly1305", "Go", chacha20poly1305.NonceSizeX} Minor icon MINOR Code Style should omit type AEADTypeEnum from declaration of var BackendXChaCha20Poly1305OpenSSL; it will be inferred from the right-hand side var BackendXChaCha20Poly1305OpenSSL AEADTypeEnum = AEADTypeEnum{"XChaCha20-Poly1305", "OpenSSL", chacha20poly1305.NonceSizeX} Found 2 possible new issues internal/cryptocore/cryptocore.go Minor icon MINOR Code Style should omit type AEADTypeEnum from declaration of var BackendOpenSSL; it will be inferred from the right-hand side var BackendOpenSSL AEADTypeEnum = AEADTypeEnum{"AES-GCM-256", "OpenSSL", 16} Minor icon MINOR Code Style should omit type AEADTypeEnum from declaration of var BackendGoGCM; it will be inferred from the right-hand side var BackendGoGCM AEADTypeEnum = AEADTypeEnum{"AES-GCM-256", "Go", 16} 2021-09-28T16:09:31+00:00 Jakob Unterwurzacher 2021-09-28T15:45:26+00:00 urn:sha1:db1824a23ac8e47cda714796e55cf6927b0cbecc Used in gocryptfs-xray, and will also be used in -info. 2021-09-10T10:14:19+00:00 Jakob Unterwurzacher 2021-09-10T10:14:19+00:00 urn:sha1:d023cd6c95fcbc6b5056ba1f425d2ac3df4abc5a The rewritten openssl backend does not support this flag anymore, and it was inherently dangerour. Drop it (ignored for compatibility) 2021-09-08T18:32:16+00:00 Jakob Unterwurzacher 2021-09-08T18:32:16+00:00 urn:sha1:94e8004b6ce497dafd13e8c3f6f6596b49169970 Now that stupidgcm supports xchacha, make it available on mount. 2021-09-07T16:15:04+00:00 Jakob Unterwurzacher 2021-09-07T16:11:11+00:00 urn:sha1:85c2beccaf674c69b3e30b0d646f5c11d91ecb9b New() -> NewAES256GCM() Also add missing NewChacha20poly1305 constructor in without_openssl.go. 2021-09-07T16:14:05+00:00 Jakob Unterwurzacher 2021-09-02T09:33:06+00:00 urn:sha1:9e1dd73e55e095b8e8b4264897c4d21fcdcdb2ae $ ./gocryptfs -speed gocryptfs v2.1-56-gdb1466f-dirty.stupidchacha; go-fuse v2.1.1-0.20210825171523-3ab5d95a30ae; 2021-09-02 go1.17 linux/amd64 AES-GCM-256-OpenSSL 529.53 MB/s AES-GCM-256-Go 833.85 MB/s (selected in auto mode) AES-SIV-512-Go 155.27 MB/s XChaCha20-Poly1305-Go 715.33 MB/s (use via -xchacha flag) XChaCha20-Poly1305-OpenSSL 468.94 MB/s https://github.com/rfjakob/gocryptfs/issues/452 2021-08-23T20:10:23+00:00 Jakob Unterwurzacher 2021-08-23T20:10:23+00:00 urn:sha1:806334eacf2e50d712844761aca2b11014ec99df Have the information in one centralized place, and access it from main as needed. 2021-08-23T14:00:41+00:00 Jakob Unterwurzacher 2021-08-21T10:08:37+00:00 urn:sha1:4764a9bde093f6b61d0370653c6c9d12949ed145 Mount flag only at the moment, not saved to gocryptfs.conf. https://github.com/rfjakob/gocryptfs/issues/452 2021-08-23T13:05:15+00:00 Jakob Unterwurzacher 2021-08-23T13:05:15+00:00 urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858 Our git version is v2+ for some time now, but go.mod still declared v1. Hopefully making both match makes https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work. All the import paths have been fixed like this: find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/% 2021-08-21T08:55:20+00:00 Jakob Unterwurzacher 2021-08-21T08:55:20+00:00 urn:sha1:2da0e13b1da4c903023200d6271b90f49077e8de The IVLen var seems be a net loss in clarity. Drop it. Also add comments and normalize error messages.