gocryptfs/cli_args_test.go, branch xattr_user_buffer Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=xattr_user_buffer 2023-05-03T19:14:53+00:00 cli: don't split multiple-strings flags on comma 2023-05-03T19:14:53+00:00 Jakob Unterwurzacher 2023-05-03T19:14:53+00:00 urn:sha1:aa1d8a0f90a1046b89dfdd9e58fb1407c76ff27e Looks like I used StringSliceVar (which splits on comma) where I should have always used StringArrayVar (which does not). Bug report contains this example of misbehavoir: #gocryptfs -extpass 'echo abc,123' -init testdir Reading password from extpass program "echo abc", arguments: ["123"] extpass cmd start failed: exec: "echo abc": executable file not found in $PATH Fixes https://github.com/rfjakob/gocryptfs/issues/730 tests: TestParseCliOpts: de-uglify testcase list 2023-05-03T18:56:36+00:00 Jakob Unterwurzacher 2023-05-03T18:56:36+00:00 urn:sha1:6c14d25d442a819bf37e228d936e6a2a05de747d cli: add -longnamemax 2021-10-21T13:58:19+00:00 Jakob Unterwurzacher 2021-10-21T13:58:19+00:00 urn:sha1:d14c9340d6fb473e9837e91db8b6e869c37ad8e5 Fixes https://github.com/rfjakob/gocryptfs/issues/499 stupidgcm: add PreferOpenSSL{AES256GCM,Xchacha20poly1305} 2021-09-08T17:48:13+00:00 Jakob Unterwurzacher 2021-09-08T17:48:13+00:00 urn:sha1:1a5866729387c09eca1cdc9737d1b02c74c25901 Add PreferOpenSSLXchacha20poly1305, rename PreferOpenSSL -> PreferOpenSSLAES256GCM. go mod: declare module version v2 2021-08-23T13:05:15+00:00 Jakob Unterwurzacher 2021-08-23T13:05:15+00:00 urn:sha1:69d88505fd7f4cb0d9e4f1918de296342fe05858 Our git version is v2+ for some time now, but go.mod still declared v1. Hopefully making both match makes https://pkg.go.dev/github.com/rfjakob/gocryptfs/v2 work. All the import paths have been fixed like this: find . -name \*.go | xargs sed -i s%github.com/rfjakob/gocryptfs/%github.com/rfjakob/gocryptfs/v2/% main: add testcases for convertToDoubleDash & parseCliOpts 2021-08-10T17:42:33+00:00 Jakob Unterwurzacher 2021-08-10T17:42:33+00:00 urn:sha1:0c16616117e9866cc49adc85738e3c9e3adf413a main: take advantage of pflag slice types 2021-08-10T17:09:58+00:00 Jakob Unterwurzacher 2021-08-10T17:09:58+00:00 urn:sha1:463f6e8962d87bf45dccd806822d40cfff335695 Our multipleStrings type is now built in. main: push TestPrefixOArgs testcase struct into TestPrefixOArgs 2021-08-10T07:33:19+00:00 Jakob Unterwurzacher 2021-08-10T07:33:19+00:00 urn:sha1:8c9a1c1121581a0d2a7e99d4ddd0fc22d8be20ed No need to have it declared globally. cli: add multipleStrings type 2018-08-11T21:25:17+00:00 Jakob Unterwurzacher 2018-08-11T21:25:17+00:00 urn:sha1:eaa5aecd422bc4f6b01b6257383521ad512e08f7 Will be used for --exclude. main: make prefixOArgs errors testable 2018-06-05T19:02:35+00:00 Jakob Unterwurzacher 2018-06-05T19:02:35+00:00 urn:sha1:e29a81efc3df88b451a4a9464724a952d97b4115 By returning an error instead of calling os.Exit, error cases can be tested easily. Error cases were not tested until now.