Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v2.5.0 2025-01-18T13:47:12+00:00 2025-01-18T13:47:12+00:00 Jakob Unterwurzacher 2025-01-18T13:47:12+00:00 urn:sha1:84c058063e1ce1d423a6284228165148b948603a 2025-01-18T13:46:14+00:00 Jakob Unterwurzacher 2025-01-18T13:46:14+00:00 urn:sha1:a0105e65cde9f4643a896770a9629da644613a8a Darwin does not have Stat_t.mtim: + go test -c -tags without_openssl -o /dev/null github.com/rfjakob/gocryptfs/v2/tests/reverse Error: tests/reverse/correctness_test.go:407:15: name_stat.Mtim undefined (type syscall.Stat_t has no field or method Mtim) Error: tests/reverse/correctness_test.go:407:37: long_stat.Mtim undefined (type syscall.Stat_t has no field or method Mtim) Error: tests/reverse/correctness_test.go:410:15: name_stat.Ctim undefined (type syscall.Stat_t has no field or method Ctim) Error: tests/reverse/correctness_test.go:410:37: long_stat.Ctim undefined (type syscall.Stat_t has no field or method Ctim) Error: tests/reverse/correctness_test.go:424:16: diriv_stat.Mtim undefined (type syscall.Stat_t has no field or method Mtim) Error: tests/reverse/correctness_test.go:424:42: workdirA_stat.Mtim undefined (type syscall.Stat_t has no field or method Mtim) Error: tests/reverse/correctness_test.go:427:16: diriv_stat.Ctim undefined (type syscall.Stat_t has no field or method Ctim) Error: tests/reverse/correctness_test.go:427:42: workdirA_stat.Ctim undefined (type syscall.Stat_t has no field or method Ctim) Switch to os.Stat. 2025-01-18T13:27:27+00:00 Jakob Unterwurzacher 2025-01-18T13:27:27+00:00 urn:sha1:38936cba4e319525875feaa5d44b85819692e056 This problem potentially causes extra disk usage for sparse files but is otherwise harmless. Skip the test for now. 2025-01-18T13:19:36+00:00 Jakob Unterwurzacher 2025-01-18T13:19:36+00:00 urn:sha1:638658fa7fdbaf2e6662945a6d3b598e9ec0a26c Closes https://github.com/rfjakob/gocryptfs/pull/883 Closes https://github.com/rfjakob/gocryptfs/security/dependabot/10 2025-01-18T13:13:52+00:00 Jakob Unterwurzacher 2025-01-18T13:11:51+00:00 urn:sha1:9eb47cf546d7e2499eab210d70050ef78087475a With inode number reuse and hard links, we could have returned wrong data for gocryptfs.diriv and gocryptfs.xyz.longname files, respectively (https://github.com/rfjakob/gocryptfs/issues/802). Now that this is fixed, ensure that rsync and similar tools pick up the new correct files by advancing mtime and ctime by 10 seconds, which should be more than any filesytems' timestamp granularity (FAT32 has 2 seconds). 2025-01-18T13:13:52+00:00 Jakob Unterwurzacher 2025-01-18T12:56:51+00:00 urn:sha1:c19f986ba09e675a5139b12bcf2687495f2533dd Will be used in a new test in the next commit. 2024-12-30T10:47:08+00:00 Paul Pazderski 2024-11-28T16:42:52+00:00 urn:sha1:1464f9d1668b9b9aa34c239eb4570c2426f95dd9 2024-12-05T20:19:17+00:00 Jakob Unterwurzacher 2024-12-05T20:16:33+00:00 urn:sha1:0192dcad72cfb7bc3edc2ea107e31f7191f62ff0 https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch 2024-12-04T18:51:33+00:00 Jakob Unterwurzacher 2024-12-04T18:51:33+00:00 urn:sha1:9529f5da0f608c7dbc7b7be095d89039d6a3a5b6 This is not a real leak: fd leak in test process? before, after: [0r=/dev/null 3r=/proc/940141/fd 5rw=anon_inode:[eventfd] (filtered: pipe:[2454797], pipe:[2454797], anon_inode:[eventpoll])] [0r=/dev/null 3r=/proc/940141/fd 5rw=anon_inode:[eventfd] 12rw=anon_inode:[pidfd] (filtered: pipe:[2454797], pipe:[2454797], anon_inode:[eventpoll], pipe:[2460158])] Ignore pidfd. 2024-12-04T18:47:43+00:00 Jakob Unterwurzacher 2024-12-04T18:47:43+00:00 urn:sha1:82dac42e85f01b1ea3383470350aa837a19f0ac3 Turns out at least the tests depended on the old behavoir. Fixes d5bd98eb3f4cbfb8dd9d0b2eb64dbff69c3c88b1