Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.7 2019-03-17T15:59:11+00:00 2019-03-17T15:59:11+00:00 Jakob Unterwurzacher 2019-03-17T15:59:11+00:00 urn:sha1:8373959c951e0557ef77ed3eb56d0c9a94fc8f8a 2019-03-17T11:48:44+00:00 Jakob Unterwurzacher 2019-03-17T11:48:44+00:00 urn:sha1:5857521b40c3d7b9a8f92d6116d398553db10a2e This should help debugging https://github.com/rfjakob/gocryptfs/issues/375 and https://github.com/rfjakob/gocryptfs/issues/274 , as MacOS does not have "stat -f". 2019-03-03T13:09:33+00:00 Jakob Unterwurzacher 2019-03-03T13:09:33+00:00 urn:sha1:cd7a6862116dc3bac11d2a67fe93f20a7afc7284 Ironically, the test for DirIV races had a data race itself by writing to a bool without taking a lock. Found by running "./test.bash -race": WARNING: DATA RACE Write at 0x00c00001dea5 by goroutine 22: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func1() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:39 +0x38 github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:73 +0x65c testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 Previous read at 0x00c00001dea5 by goroutine 23: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace.func2() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:51 +0x8b Goroutine 22 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:916 +0x699 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1157 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 testing.runTests() /usr/local/go/src/testing/testing.go:1155 +0x523 testing.(*M).Run() /usr/local/go/src/testing/testing.go:1072 +0x2eb github.com/rfjakob/gocryptfs/tests/defaults.TestMain() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/main_test.go:21 +0xe1 main.main() _testmain.go:76 +0x222 Goroutine 23 (running) created at: github.com/rfjakob/gocryptfs/tests/defaults.TestDirIVRace() /home/jakob/go/src/github.com/rfjakob/gocryptfs/tests/defaults/diriv_test.go:43 +0x48d testing.tRunner() /usr/local/go/src/testing/testing.go:865 +0x163 ================== --- FAIL: TestDirIVRace (0.00s) testing.go:809: race detected during execution of test FAIL 2019-03-03T12:25:30+00:00 Jakob Unterwurzacher 2019-03-03T12:25:30+00:00 urn:sha1:cf27037f20723e934320edeff7f8aa356bdca467 To support arguments containing spaces, -extpass can now be passed multiple times. https://github.com/rfjakob/gocryptfs/issues/289 2019-03-02T14:43:58+00:00 Jakob Unterwurzacher 2019-03-02T14:40:05+00:00 urn:sha1:61940a9c0666eba8be21de4f1cd182912f74f929 This gives users who build from the source tarball, but do not want to install pandoc, access to the man pages. Apperently the gocryptfs homebrew package ships without the man pages at the moment to avoid pandoc. Requested at https://github.com/rfjakob/gocryptfs/issues/355 2019-03-02T13:45:28+00:00 Jakob Unterwurzacher 2019-03-02T13:45:28+00:00 urn:sha1:60cae5063fe7bdfde6a24ea840c5076a368ad3ea go-fuse now has a v1.0.0. release! https://github.com/hanwen/go-fuse/releases/tag/v1.0.0 2019-03-02T13:39:03+00:00 Jakob Unterwurzacher 2019-03-02T13:39:03+00:00 urn:sha1:ddcc1fb3aa6bcbecf26f537323dd71889873b48f Also add Go 1.12 to Travis. 2019-02-17T16:25:41+00:00 Jakob Unterwurzacher 2019-02-17T16:25:41+00:00 urn:sha1:173218895c55f381750408d9452d118b8c574f58 Error was: tests/matrix/matrix_test.go:101:9: no new variables on left side of := 2019-02-17T16:13:20+00:00 Jakob Unterwurzacher 2019-02-17T16:13:20+00:00 urn:sha1:179471b6486b2cb3e6e24eed1d9f86f2e880e334 Should help debugging https://github.com/rfjakob/gocryptfs/issues/363 2019-02-17T16:05:05+00:00 Jakob Unterwurzacher 2019-02-17T16:05:05+00:00 urn:sha1:19cb6d046aac92f44722c17ba9a371b08ca0be6a Looks like we allowed creating longer names by accident. Fix that, and add a test that verifies it.