Mirror of gocryptfs source code on Github http://nuetzlich.net/cgit/gocryptfs/atom?h=v1.4.1 2017-08-21T18:39:25+00:00 2017-08-21T18:39:25+00:00 Jakob Unterwurzacher 2017-08-21T17:38:15+00:00 urn:sha1:a605e8fed0f2cf7582c68901e3ed4f6c26a3bdfa 2017-08-21T12:10:05+00:00 Jakob Unterwurzacher 2017-08-21T12:10:05+00:00 urn:sha1:07f57314afb260d6b14227b932d66345c55ffab3 The local user id of the packager is not interesting for users who download the tarball. Also it will cause the gocryptfs binary to have an unintended owner when the tarball is extraced as root. Fix the issue by using "tar --owner=root --group=root" which overwrites user and group id with zero. 2017-08-16T16:33:00+00:00 Jakob Unterwurzacher 2017-08-16T16:33:00+00:00 urn:sha1:312ea32bb70abb93be315d0b7c442d5c4ae571d9 The benchmark that supported the decision for 512-byte prefetching previously lived outside the repo. Let's add it where it belongs so it cannot get lost. 2017-08-15T17:13:00+00:00 Jakob Unterwurzacher 2017-08-15T17:13:00+00:00 urn:sha1:838bf883df579a414289a3e05d238c582ac78523 For some reason, writing became a lot faster in Linux 4.11 (scheduler improvements?). 2017-08-15T17:07:08+00:00 Jakob Unterwurzacher 2017-08-15T17:07:08+00:00 urn:sha1:069647842c0e0fc988bb69c40a9de442ec20080d 2017-08-15T17:04:02+00:00 Jakob Unterwurzacher 2017-08-15T17:03:07+00:00 urn:sha1:d5671b785a79452d27dd3fc34dc54ef585c8bf0b 2017-08-15T17:04:02+00:00 Jakob Unterwurzacher 2017-08-15T16:35:30+00:00 urn:sha1:989b88098951e5ad68b66049e59fd2ca475c4711 Getdents avoids calling Lstat on each file. 2017-08-15T17:03:57+00:00 Jakob Unterwurzacher 2017-08-13T19:13:44+00:00 urn:sha1:e50a6a57e57bc3cc925ba9a6e7f4dc1da4da3c84 The Readdir function provided by os is inherently slow because it calls Lstat on all files. Getdents gives us all the information we need, but does not have a proper wrapper in the stdlib. Implement the "Getdents()" wrapper function that calls syscall.Getdents() and parses the returned byte blob to a fuse.DirEntry slice. 2017-08-15T10:52:40+00:00 Jakob Unterwurzacher 2017-08-15T10:48:02+00:00 urn:sha1:affb1c2f6617d66bdc9fda41b017e0de000c3691 When you run "go vet" explicitely against go1.4.go, it ignores the "+build !go1.5" tag and, of course, throws a syntax error: $ go vet go1.4.go can't load package: package main: go1.4.go:5:1: expected 'package', found 'STRING' "You need Go 1.5 or higher to compile gocryptfs!" Unfortunatey, this is how https://goreportcard.com/ seems to call "go vet", and means we get 0% on the "go vet" test and see this error: An error occurred while running this test (strconv.Atoi: parsing " go1.4.go": invalid syntax) By reworking the logic to use a non-existant package we get an uglier error $ GOROOT=/opt/go1.4.3 /opt/go1.4.3/bin/go build go1.4.go:7:8: cannot find package "You_need_Go_1.5_or_higher_to_compile_gocryptfs" in any of: /opt/go1.4.3/src/You_need_Go_1.5_or_higher_to_compile_gocryptfs (from $GOROOT) /home/jakob/go/src/You_need_Go_1.5_or_higher_to_compile_gocryptfs (from $GOPATH) profiling.go:6:2: cannot find package "runtime/trace" in any of: /opt/go1.4.3/src/runtime/trace (from $GOROOT) /home/jakob/go/src/runtime/trace (from $GOPATH) but make "go vet" happy. 2017-08-11T17:02:26+00:00 Jakob Unterwurzacher 2017-08-11T16:42:30+00:00 urn:sha1:0c520845f3623eff28f0277a52e3ccffd928f5c2 Remove the "Masterkey" field from fusefrontend.Args because it should not be stored longer than neccessary. Instead pass the masterkey as a separate argument to the filesystem initializers. Then overwrite it with zeros immediately so we don't have to wait for garbage collection. Note that the crypto implementation still stores at least a masterkey-derived value, so this change makes it harder, but not impossible, to extract the encryption keys from memory. Suggested at https://github.com/rfjakob/gocryptfs/issues/137